Page MenuHomePhabricator

Rename `PHIDType` classes
ClosedPublic

Authored by joshuaspence on Jul 19 2014, 11:53 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5655: Standardize naming conventions
Commits
Restricted Diffusion Commit
rP97a8700e4589: Rename `PHIDType` classes
Summary

Ref T5655. Rename PhabricatorPHIDType subclasses for clarity (see discussion in D9839). I'm not too keen on some of the resulting class names, so feel free to suggest alternatives.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Rename `PHIDType` classes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Some of these names are a bit cumbersome, but I think that's just the price we pay for consistency.

This revision is now accepted and ready to land.Jul 21 2014, 2:07 PM

Although less consistent, I somewhat think that PhabricatorApplicationApplicationPHIDType would be better as PhabricatorApplicationPHIDType, for example.

bizrad6 added inline comments.
resources/sql/patches/20131020.pxactionmig.php
51

I think this one was missed. Should be:

PhabricatorProjectProjectPHIDType::TYPECONST);