Page MenuHomePhabricator
Differential D9947

Change the mode of the directory created by `PhutilKeyValueCacheDirectory`
ClosedPublic
Actions

Authored by joshuaspence on Jul 16 2014, 5:41 AM.
Tags
None
Referenced Files
F14095802: D9947.diff
Mon, Nov 25, 11:47 PM
F14093817: D9947.id.diff
Mon, Nov 25, 12:59 PM
Unknown Object (File)
Sat, Nov 23, 11:54 PM
Unknown Object (File)
Fri, Nov 22, 1:59 AM
Unknown Object (File)
Mon, Nov 18, 2:32 PM
Unknown Object (File)
Wed, Nov 13, 4:27 PM
Unknown Object (File)
Sun, Nov 10, 4:29 AM
Unknown Object (File)
Fri, Nov 1, 3:16 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUd8c026530d7f: Change the mode of the directory created by `PhutilKeyValueCacheDirectory`
Summary

Change the mode of the directory created by PhutilKeyValueCacheDirectory from 0777 to 0755. In general, this directory shouldn't need g+x or o+x permissions.

Test Plan

Ran diviner generate and checked the permissions on the .divinercache directory.

Diff Detail

Repository
rPHU libphutil
Branch
cachedir-0775
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1726
Build 1727: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23859.Jul 16 2014, 5:41 AM
joshuaspence retitled this revision from to Change the mode of the directory created by `PhutilKeyValueCacheDirectory`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 16 2014, 5:41 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1712: Diff 23859.Jul 16 2014, 5:42 AM
epriestley accepted this revision.Jul 16 2014, 11:49 AM
epriestley edited edge metadata.

Something like 755 or even 700 would probably be fine, too.

This revision is now accepted and ready to land.Jul 16 2014, 11:49 AM
joshuaspence updated this object.Jul 16 2014, 12:37 PM
joshuaspence edited edge metadata.
joshuaspence updated this revision to Diff 23881.Jul 16 2014, 12:37 PM
joshuaspence updated this object.
  • Demote permissions from 0775 to 0755.
joshuaspence updated this object.Jul 16 2014, 12:38 PM
Harbormaster completed remote builds in B1726: Diff 23881.Jul 16 2014, 12:39 PM
joshuaspence closed this revision.Jul 16 2014, 12:39 PM
joshuaspence updated this revision to Diff 23882.

Closed by commit rPHUd8c026530d7f (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
cache/
4 lines

Diff 23881

View Options

src/cache/PhutilKeyValueCacheDirectory.php

Loading...
Phabricator · Built by Phacility