Change the mode of the directory created by `PhutilKeyValueCacheDirectory`
ClosedPublic
Actions

Authored by joshuaspence on Jul 16 2014, 5:41 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUd8c026530d7f: Change the mode of the directory created by `PhutilKeyValueCacheDirectory`

Summary

Change the mode of the directory created by PhutilKeyValueCacheDirectory from 0777 to 0755. In general, this directory shouldn't need g+x or o+x permissions.

Test Plan

Ran diviner generate and checked the permissions on the .divinercache directory.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23859.Jul 16 2014, 5:41 AM

joshuaspence retitled this revision from to Change the mode of the directory created by `PhutilKeyValueCacheDirectory`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 16 2014, 5:41 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1712: Diff 23859.Jul 16 2014, 5:42 AM

Something like 755 or even 700 would probably be fine, too.

This revision is now accepted and ready to land.Jul 16 2014, 11:49 AM

joshuaspence updated this object.Jul 16 2014, 12:37 PM

joshuaspence edited edge metadata.

Demote permissions from 0775 to 0755.

joshuaspence updated this object.Jul 16 2014, 12:38 PM

Harbormaster completed remote builds in B1726: Diff 23881.Jul 16 2014, 12:39 PM

Closed by commit rPHUd8c026530d7f (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

cache/

PhutilKeyValueCacheDirectory.php

4 lines

Diff 23882

View Options

src/cache/PhutilKeyValueCacheDirectory.php

Change the mode of the directory created by `PhutilKeyValueCacheDirectory`ClosedPublicActions