Page MenuHomePhabricator
Differential D9944

Rename the `support/jshint` directory.
ClosedPublic
Actions

Authored by joshuaspence on Jul 16 2014, 2:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 5, 6:04 AM
Unknown Object (File)
Fri, May 3, 9:05 AM
Unknown Object (File)
Thu, Apr 25, 2:10 AM
Unknown Object (File)
Wed, Apr 24, 11:49 PM
Unknown Object (File)
Sat, Apr 20, 7:21 PM
Unknown Object (File)
Tue, Apr 16, 2:03 AM
Unknown Object (File)
Fri, Apr 12, 10:55 PM
Unknown Object (File)
Fri, Apr 12, 6:26 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP13590b9e3def: Rename the `support/jshint` directory.
Summary

It is somewhat overkill to use an entire directory for a single file (the configuration file for JSHint). Instead, rename the directory so that it could (theoretically) be used for other linter configuration files.

Test Plan

Ran arc lint -- webroot/rsrc/js/core/phtize.js just to make sure everything still works.

Diff Detail

Repository
rP Phabricator
Branch
jshintrc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1708
Build 1709: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23855.Jul 16 2014, 2:41 AM
joshuaspence retitled this revision from to Rename the `support/jshint` directory..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 16 2014, 2:41 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1708: Diff 23855.Jul 16 2014, 2:42 AM
joshuaspence updated this revision to Diff 23856.Jul 16 2014, 2:42 AM
joshuaspence edited edge metadata.
  • Change the path for the JSON linter as well.
Harbormaster completed remote builds in B1709: Diff 23856.Jul 16 2014, 2:43 AM
epriestley accepted this revision.Jul 16 2014, 11:47 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2014, 11:47 AM
joshuaspence closed this revision.Jul 16 2014, 12:08 PM
joshuaspence updated this revision to Diff 23871.

Closed by commit rP13590b9e3def (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
2 lines
support/
jshint/
lint/
jshint/
jshintrc
jshintconfig
22 lines

Diff 23855

View Options

.arclint

Loading...
View Options

support/jshint/jshintconfig

Loading...
View Options

support/lint/jshintrc

Loading...
Phabricator · Built by Phacility