Page MenuHomePhabricator
Differential D9941

Move Aphront to `libphutil`
AbandonedPublic
Actions

Authored by joshuaspence on Jul 16 2014, 1:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 2:34 AM
Unknown Object (File)
Sun, Apr 14, 4:59 PM
Unknown Object (File)
Fri, Apr 5, 1:28 PM
Unknown Object (File)
Tue, Apr 2, 4:14 AM
Unknown Object (File)
Sat, Mar 23, 7:54 PM
Unknown Object (File)
Sat, Mar 23, 7:54 PM
Unknown Object (File)
Sat, Mar 23, 7:54 PM
Unknown Object (File)
Wed, Mar 20, 12:01 PM
View All Files
Subscribers
chad
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T1806: Move Aphront to libphutil
Summary

Fixes T1806. Move Aphront to libphutil and making it usable as a standalone web stack, independent of Phabricator.

Test Plan

Browsed around a couple of pages in Phabricator... everything seemed to load just fine.

Diff Detail

Event Timeline

joshuaspence updated this revision to Diff 23851.Jul 16 2014, 1:54 AM
joshuaspence retitled this revision from to Move Aphront to `libphutil`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T1806: Move Aphront to libphutil.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 16 2014, 1:54 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1705: Diff 23851.Jul 16 2014, 1:55 AM
joshuaspence edited the test plan for this revision. (Show Details)Jul 16 2014, 2:10 AM
joshuaspence edited edge metadata.
joshuaspence updated this revision to Diff 23861.Jul 16 2014, 8:08 AM
  • Move src/view from Phabricator as well
Harbormaster completed remote builds in B1714: Diff 23861.Jul 16 2014, 8:09 AM
joshuaspence updated this revision to Diff 23862.Jul 16 2014, 8:10 AM
  • Moved src/view to src/aphront/view
Harbormaster completed remote builds in B1715: Diff 23862.Jul 16 2014, 8:11 AM
joshuaspence added a comment.Jul 16 2014, 12:22 PM

(The idea here was to move everything that didn't seem too Phabricator-specific. In particular, I didn't move any classes that were prefixed with Phabricator.)

chad added a subscriber: chad.Jul 16 2014, 2:36 PM

PHUI is "Phabricator UI", and many of these classes just haven't been modernized to be designated as "PHUI". I have some expectation that all the UI lives in one repo so I don't have to worry about making sure something exists.

chad added a comment.Jul 16 2014, 2:42 PM

Oh I see @epriestley commented on the task.

joshuaspence abandoned this revision.Jul 16 2014, 10:26 PM

See T1806#11

Large Diff

This large diff affects 120 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
235 lines
aphront/
83 lines
611 lines
50 lines
__tests__/
151 lines
configuration/
231 lines
315 lines
exception/
5 lines
5 lines
21 lines
response/
16 lines
13 lines
36 lines
23 lines
77 lines
20 lines
92 lines
13 lines
41 lines
22 lines
71 lines
88 lines
19 lines
147 lines
16 lines
sink/
119 lines
36 lines
26 lines
__tests__/
82 lines
view/
344 lines
71 lines
9 lines
158 lines
162 lines
control/
41 lines
178 lines
229 lines
325 lines
107 lines
67 lines
form/
96 lines
109 lines
135 lines
55 lines
224 lines
278 lines
control/
52 lines
96 lines
249 lines
94 lines
329 lines
13 lines
19 lines
36 lines
13 lines
21 lines
230 lines
71 lines
62 lines
13 lines
81 lines
13 lines
45 lines
91 lines
55 lines
57 lines
52 lines
120 lines
39 lines
13 lines
21 lines
61 lines
layout/
29 lines
118 lines
12 lines
57 lines
150 lines
106 lines
301 lines
66 lines
__tests__/
141 lines
page/
82 lines
27 lines
phui/
59 lines
169 lines
47 lines
42 lines
147 lines
188 lines
275 lines
273 lines
589 lines
116 lines
118 lines
250 lines
193 lines
285 lines
135 lines
647 lines
133 lines
37 lines
24 lines
266 lines
134 lines
111 lines
34 lines
251 lines
20 lines
557 lines
133 lines
82 lines
102 lines
calendar/
126 lines
308 lines
39 lines
widget/
16 lines
120 lines
bars/
63 lines
102 lines
57 lines

Diff 23862

View Options

src/__phutil_library_map__.php

View Options

src/aphront/AphrontController.php

View Options

src/aphront/AphrontRequest.php

View Options

src/aphront/AphrontURIMapper.php

View Options

src/aphront/__tests__/AphrontRequestTestCase.php

View Options

src/aphront/configuration/AphrontApplicationConfiguration.php

View Options

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php

View Options

src/aphront/exception/AphrontCSRFException.php

View Options

src/aphront/exception/AphrontException.php

View Options

src/aphront/exception/AphrontUsageException.php

View Options

src/aphront/response/Aphront304Response.php

View Options

src/aphront/response/Aphront400Response.php

View Options

src/aphront/response/Aphront403Response.php

View Options

src/aphront/response/Aphront404Response.php

View Options

src/aphront/response/AphrontAjaxResponse.php

View Options

src/aphront/response/AphrontDialogResponse.php

View Options

src/aphront/response/AphrontFileResponse.php

View Options

src/aphront/response/AphrontHTMLResponse.php

View Options

src/aphront/response/AphrontJSONResponse.php

View Options

src/aphront/response/AphrontPlainTextResponse.php

View Options

src/aphront/response/AphrontProxyResponse.php

View Options

src/aphront/response/AphrontRedirectResponse.php

View Options

src/aphront/response/AphrontReloadResponse.php

View Options

src/aphront/response/AphrontResponse.php

View Options

src/aphront/response/AphrontWebpageResponse.php

View Options

src/aphront/sink/AphrontHTTPSink.php

View Options

src/aphront/sink/AphrontIsolatedHTTPSink.php

View Options

src/aphront/sink/AphrontPHPHTTPSink.php

View Options

src/aphront/sink/__tests__/AphrontHTTPSinkTestCase.php

View Options

src/aphront/view/AphrontDialogView.php

View Options

src/aphront/view/AphrontJavelinView.php

View Options

src/aphront/view/AphrontNullView.php

View Options

src/aphront/view/AphrontTagView.php

View Options

src/aphront/view/AphrontView.php

View Options

src/aphront/view/control/AphrontAbstractAttachedFileView.php

View Options

src/aphront/view/control/AphrontCursorPagerView.php

View Options

src/aphront/view/control/AphrontPagerView.php

View Options

src/aphront/view/control/AphrontTableView.php

View Options

src/aphront/view/control/AphrontTokenizerTemplateView.php

View Options

src/aphront/view/control/AphrontTypeaheadTemplateView.php

View Options

src/aphront/view/form/AphrontErrorView.php

View Options

src/aphront/view/form/AphrontFormInsetView.php

View Options

src/aphront/view/form/AphrontFormView.php

View Options

src/aphront/view/form/PHUIFormLayoutView.php

View Options

src/aphront/view/form/PHUIFormPageView.php

View Options

src/aphront/view/form/PHUIPagedFormView.php

View Options

src/aphront/view/form/control/AphrontFormCheckboxControl.php

View Options

src/aphront/view/form/control/AphrontFormChooseButtonControl.php

View Options

src/aphront/view/form/control/AphrontFormControl.php

View Options

src/aphront/view/form/control/AphrontFormCropControl.php

View Options

src/aphront/view/form/control/AphrontFormDateControl.php

View Options

src/aphront/view/form/control/AphrontFormDividerControl.php

View Options

src/aphront/view/form/control/AphrontFormFileControl.php

View Options

src/aphront/view/form/control/AphrontFormImageControl.php

View Options

src/aphront/view/form/control/AphrontFormMarkupControl.php

View Options

src/aphront/view/form/control/AphrontFormPasswordControl.php

View Options

src/aphront/view/form/control/AphrontFormPolicyControl.php

View Options

src/aphront/view/form/control/AphrontFormRadioButtonControl.php

View Options

src/aphront/view/form/control/AphrontFormRecaptchaControl.php

View Options

src/aphront/view/form/control/AphrontFormSectionControl.php

View Options

src/aphront/view/form/control/AphrontFormSelectControl.php

View Options

src/aphront/view/form/control/AphrontFormStaticControl.php

View Options

src/aphront/view/form/control/AphrontFormSubmitControl.php

View Options

src/aphront/view/form/control/AphrontFormTextAreaControl.php

View Options

src/aphront/view/form/control/AphrontFormTextControl.php

View Options

src/aphront/view/form/control/AphrontFormTextWithSubmitControl.php

View Options

src/aphront/view/form/control/AphrontFormToggleButtonsControl.php

View Options

src/aphront/view/form/control/AphrontFormTokenizerControl.php

View Options

src/aphront/view/form/control/AphrontFormTypeaheadControl.php

View Options

src/aphront/view/form/control/PHUIFormDividerControl.php

View Options

src/aphront/view/form/control/PHUIFormFreeformDateControl.php

View Options

src/aphront/view/form/control/PHUIFormMultiSubmitControl.php

View Options

src/aphront/view/layout/AphrontContextBarView.php

View Options

src/aphront/view/layout/AphrontListFilterView.php

View Options

src/aphront/view/layout/AphrontMiniPanelView.php

View Options

src/aphront/view/layout/AphrontMoreView.php

View Options

src/aphront/view/layout/AphrontMultiColumnView.php

View Options

src/aphront/view/layout/AphrontPanelView.php

View Options

src/aphront/view/layout/AphrontSideNavFilterView.php

View Options

src/aphront/view/layout/AphrontTwoColumnView.php

View Options

src/aphront/view/layout/__tests__/PHUIListViewTestCase.php

View Options

src/aphront/view/page/AphrontPageView.php

View Options

src/aphront/view/page/AphrontRequestFailureView.php

View Options

src/aphront/view/phui/PHUI.php

View Options

src/aphront/view/phui/PHUIActionHeaderView.php

View Options

src/aphront/view/phui/PHUIBoxView.php

View Options

src/aphront/view/phui/PHUIButtonBarView.php

View Options

src/aphront/view/phui/PHUIButtonView.php

View Options

src/aphront/view/phui/PHUIDocumentView.php

View Options

src/aphront/view/phui/PHUIFeedStoryView.php

View Options

src/aphront/view/phui/PHUIHeaderView.php

View Options

src/aphront/view/phui/PHUIIconView.php

View Options

src/aphront/view/phui/PHUIImageMaskView.php

View Options

src/aphront/view/phui/PHUIInfoPanelView.php

View Options

src/aphront/view/phui/PHUIListItemView.php

View Options

src/aphront/view/phui/PHUIListView.php

View Options

src/aphront/view/phui/PHUIObjectBoxView.php

View Options

src/aphront/view/phui/PHUIObjectItemListView.php

View Options

src/aphront/view/phui/PHUIObjectItemView.php

View Options

src/aphront/view/phui/PHUIPinboardItemView.php

View Options

src/aphront/view/phui/PHUIPinboardView.php

View Options

src/aphront/view/phui/PHUIPropertyGroupView.php

View Options

src/aphront/view/phui/PHUIPropertyListView.php

View Options

src/aphront/view/phui/PHUIRemarkupPreviewPanel.php

View Options

src/aphront/view/phui/PHUIStatusItemView.php

View Options

src/aphront/view/phui/PHUIStatusListView.php

View Options

src/aphront/view/phui/PHUITagView.php

View Options

src/aphront/view/phui/PHUITextView.php

View Options

src/aphront/view/phui/PHUITimelineEventView.php

View Options

src/aphront/view/phui/PHUITimelineView.php

View Options

src/aphront/view/phui/PHUIWorkboardView.php

View Options

src/aphront/view/phui/PHUIWorkpanelView.php

View Options

src/aphront/view/phui/calendar/PHUICalendarListView.php

View Options

src/aphront/view/phui/calendar/PHUICalendarMonthView.php

View Options

src/aphront/view/phui/calendar/PHUICalendarWidgetView.php

View Options

src/aphront/view/widget/AphrontKeyboardShortcutsAvailableView.php

View Options

src/aphront/view/widget/AphrontStackTraceView.php

View Options

src/aphront/view/widget/bars/AphrontBarView.php

View Options

src/aphront/view/widget/bars/AphrontGlyphBarView.php

View Options

src/aphront/view/widget/bars/AphrontProgressBarView.php

Phabricator · Built by Phacility