This moves the date and time utility functions that are not user-dependent into libphutil.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPHU9d53680db8f4: Move date and time utility functions to libphutil
Generated library maps and viewed Phabricator instance.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- datetime-move
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1660 Build 1661: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Is it plausible to rename these to phutil_ (instead of phabricator_) as we do this? Phabricator needs to be updated anyway...
Comment Actions
Slightly worried about the breakage of external code if we rename them. Maybe the best way is:
- Rename these methods
- In the Phabricator codebase, change things to use phutil_
- Add some proxy methods to Phabricator with the old names for any external modules that might still be making calls
- Deprecated and remove the proxy methods at some point in the future?
Or maybe we just rename the methods and let things break? I don't really know what the best option is.
Comment Actions
Or maybe we just rename the methods and let things break? I don't really know what the best option is.
I think this is fine. The breaks will be really obvious, easy to fix, not do anything bad (data loss / corruption / etc) and these aren't very commonly-used methods.