Page MenuHomePhabricator

Move date and time utility functions to libphutil
ClosedPublic

Authored by hach-que on Jul 12 2014, 2:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 2:47 AM
Unknown Object (File)
Sun, Mar 10, 2:47 AM
Unknown Object (File)
Sun, Mar 10, 2:43 AM
Unknown Object (File)
Tue, Mar 5, 10:52 AM
Unknown Object (File)
Feb 24 2024, 2:16 AM
Unknown Object (File)
Feb 9 2024, 7:32 PM
Unknown Object (File)
Feb 1 2024, 11:47 PM
Unknown Object (File)
Jan 13 2024, 11:51 AM
Subscribers

Details

Summary

This moves the date and time utility functions that are not user-dependent into libphutil.

Test Plan

Generated library maps and viewed Phabricator instance.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Move date and time utility functions to libphutil.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.

Is it plausible to rename these to phutil_ (instead of phabricator_) as we do this? Phabricator needs to be updated anyway...

Slightly worried about the breakage of external code if we rename them. Maybe the best way is:

  • Rename these methods
  • In the Phabricator codebase, change things to use phutil_
  • Add some proxy methods to Phabricator with the old names for any external modules that might still be making calls
  • Deprecated and remove the proxy methods at some point in the future?

Or maybe we just rename the methods and let things break? I don't really know what the best option is.

Or maybe we just rename the methods and let things break? I don't really know what the best option is.

I think this is fine. The breaks will be really obvious, easy to fix, not do anything bad (data loss / corruption / etc) and these aren't very commonly-used methods.

hach-que edited edge metadata.

Renamed methods to phutil_

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 12 2014, 6:09 PM
hach-que updated this revision to Diff 23802.

Closed by commit rPHU9d53680db8f4 (authored by @hach-que).