Page MenuHomePhabricator

Use `git diff a b` for ranges, not `git diff a..b`
ClosedPublic

Authored by epriestley on Jul 11 2014, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 3:59 AM
Unknown Object (File)
Fri, Mar 15, 3:59 AM
Unknown Object (File)
Feb 23 2024, 1:14 AM
Unknown Object (File)
Feb 10 2024, 5:10 AM
Unknown Object (File)
Feb 8 2024, 9:50 AM
Unknown Object (File)
Feb 7 2024, 7:04 AM
Unknown Object (File)
Feb 4 2024, 4:38 AM
Unknown Object (File)
Jan 31 2024, 7:01 AM
Subscribers

Details

Summary

These are documented as being identical, but git diff a b works if a is a tree (for example, 4b825d..., the empty tree hash), but git diff a..b does not.

Particularly, with the a..b form, arc diff --base arc:empty does not work. With the a b form, it does.

Test Plan

Ran arc diff --base arc:empty in a repository and got a diff.

Diff Detail

Repository
rARC Arcanist
Branch
empty
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1648
Build 1649: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Use `git diff a b` for ranges, not `git diff a..b`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: talshiri, btrahan.
talshiri edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2014, 5:43 PM
epriestley updated this revision to Diff 23770.

Closed by commit rARCf9f2092246d2 (authored by @epriestley).