Page MenuHomePhabricator

Use `git diff a b` for ranges, not `git diff a..b`
ClosedPublic

Authored by epriestley on Jul 11 2014, 4:57 PM.
Tags
None
Referenced Files
F18658966: D9898.id23763.diff
Tue, Sep 23, 9:15 AM
F18618507: D9898.id23770.diff
Mon, Sep 15, 12:19 AM
F18596936: D9898.id23770.diff
Sat, Sep 13, 1:49 AM
F18594596: D9898.id23763.diff
Fri, Sep 12, 6:43 PM
F18590630: D9898.id23770.diff
Fri, Sep 12, 6:37 AM
F18586297: D9898.id23763.diff
Thu, Sep 11, 6:11 PM
F18190081: D9898.id23770.diff
Aug 16 2025, 11:22 PM
F18152916: D9898.id23763.diff
Aug 14 2025, 7:20 PM
Subscribers

Details

Summary

These are documented as being identical, but git diff a b works if a is a tree (for example, 4b825d..., the empty tree hash), but git diff a..b does not.

Particularly, with the a..b form, arc diff --base arc:empty does not work. With the a b form, it does.

Test Plan

Ran arc diff --base arc:empty in a repository and got a diff.

Diff Detail

Repository
rARC Arcanist
Branch
empty
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1648
Build 1649: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Use `git diff a b` for ranges, not `git diff a..b`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: talshiri, btrahan.
talshiri edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2014, 5:43 PM
epriestley updated this revision to Diff 23770.

Closed by commit rARCf9f2092246d2 (authored by @epriestley).