Use `git diff a b` for ranges, not `git diff a..b`
ClosedPublic
Actions

Authored by epriestley on Jul 11 2014, 4:57 PM.

Details

Reviewers

btrahan
talshiri

Commits

rARCf9f2092246d2: Use `git diff a b` for ranges, not `git diff a..b`

Summary

These are documented as being identical, but git diff a b works if a is a tree (for example, 4b825d..., the empty tree hash), but git diff a..b does not.

Particularly, with the a..b form, arc diff --base arc:empty does not work. With the a b form, it does.

Test Plan

Ran arc diff --base arc:empty in a repository and got a diff.

Diff Detail

Repository

rARC Arcanist

Branch

empty

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1648
Build 1649: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23763.Jul 11 2014, 4:57 PM

epriestley retitled this revision from to Use `git diff a b` for ranges, not `git diff a..b`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: talshiri, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 11 2014, 4:57 PM

Harbormaster completed remote builds in B1648: Diff 23763.Jul 11 2014, 4:58 PM

talshiri accepted this revision.Jul 11 2014, 5:43 PM

talshiri edited edge metadata.

This revision is now accepted and ready to land.Jul 11 2014, 5:43 PM

Closed by commit rARCf9f2092246d2 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

17 lines

Diff 23763

View Options

src/repository/api/ArcanistGitAPI.php

Use `git diff a b` for ranges, not `git diff a..b`ClosedPublicActions