Page MenuHomePhabricator

Give projects a proper on-demand datasource
ClosedPublic

Authored by epriestley on Jul 11 2014, 2:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 8:47 AM
Unknown Object (File)
Wed, May 1, 9:59 AM
Unknown Object (File)
Thu, Apr 25, 10:55 PM
Unknown Object (File)
Thu, Apr 25, 10:55 PM
Unknown Object (File)
Thu, Apr 25, 10:55 PM
Unknown Object (File)
Wed, Apr 24, 11:04 PM
Unknown Object (File)
Sat, Apr 20, 7:19 PM
Unknown Object (File)
Fri, Apr 12, 2:14 AM
Subscribers
Tokens
"Evil Spooky Haunted Tree" token, awarded by joshuaspence.

Details

Summary

Fixes T5614. Ref T4420. Other than the "users" datasource and a couple of others, many datasources ignore what the user typed and just return all results, then rely on the client to filter them.

This works fine for rarely used ("legalpad documents") or always small ("task priorities", "applications") datasets, but is something we should graudally move away from as datasets get larger.

Add a token table to projects, populate it, and use it to drive the datasource query. Additionally, expose it on the applicationsearch UI.

Test Plan
  • Ran migration.
  • Manually checked the table.
  • Searched for projects by name from ApplicationSearch.
  • Searched for projects by name from typeahead.
  • Manually checked the typeahead response.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Give projects a proper on-demand datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 10:34 PM

I'm going to address T5614 here too so we don't have to migrate twice.

epriestley edited edge metadata.
  • Include all slugs in the tokenization.
  • Include all slugs in the matching name.
  • Tested by adding slugs like #quack to project Ducks, then searching for #quack and quack to find Ducks.
epriestley updated this revision to Diff 23958.

Closed by commit rPa115810912e7 (authored by @epriestley).