Show file where syntax error occurred in library map builder
ClosedPublic
Actions

Authored by epriestley on Jul 10 2014, 11:06 PM.

Details

Reviewers

joshuaspence

Maniphest Tasks

T5597: `arc liberate` no longer shows which file has a syntax error when it encounters one

Commits

rPHU42471f314d0e: Show file where syntax error occurred in library map builder

Summary

Fixes T5597. This information is pretty useful but was inadvertently dropped while cleaning up some other stuff.

Test Plan

Ran arc liberate, was told which file has the issue.

Diff Detail

Repository

rPHU libphutil

Branch

synfile

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1621
Build 1622: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23723.Jul 10 2014, 11:06 PM

epriestley retitled this revision from to Show file where syntax error occurred in library map builder.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: joshuaspence.

epriestley added a task: T5597: `arc liberate` no longer shows which file has a syntax error when it encounters one.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 10 2014, 11:06 PM

Harbormaster completed remote builds in B1621: Diff 23723.Jul 10 2014, 11:07 PM

joshuaspence accepted this revision.Jul 10 2014, 11:08 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Jul 10 2014, 11:08 PM

After using this for a bit, it might be nice to do some resolve path / readable path juggling, but I think this is reasonable for the moment.

Closed by commit rPHU42471f314d0e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

moduleutils/

PhutilLibraryMapBuilder.php

2 lines

Diff 23723

View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Show file where syntax error occurred in library map builderClosedPublicActions