Paths

Table of Contentst

Differential D9870

Fix duplicated "Done" output
ClosedPublic
Actions

Authored by joshuaspence on Jul 10 2014, 3:30 AM.

Tags

None

Referenced Files

	F13186435: D9870.diff
	Sat, May 11, 3:37 AM

	Unknown Object (File)
	Tue, May 7, 5:36 AM

	Unknown Object (File)
	Fri, May 3, 8:54 AM

	Unknown Object (File)
	Fri, May 3, 3:47 AM

	Unknown Object (File)
	Mon, Apr 29, 2:52 PM

	Unknown Object (File)
	Wed, Apr 24, 10:17 PM

	Unknown Object (File)
	Apr 12 2024, 1:48 PM

	Unknown Object (File)
	Apr 1 2024, 1:39 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHUa1d23b911a3d: Fix duplicated "Done" output

Summary

PhutilLibraryMapBuilder outputs "Done" twice, once implicitly from PhutilConsoleProgressBar and another explicitly.

Test Plan

Before

> arc liberate src
Finding source files...
Found 350 files.
Loading symbol cache...
Found 0 files in cache.
Analyzing 350 files with 8 subprocesses...
Done.

Done.
Building library map...
Writing map...

After

> arc liberate src
Finding source files...
Found 350 files.
Loading symbol cache...
Found 349 files in cache.
Analyzing 1 files with 8 subprocesses...
Done.
Building library map...
Writing map...

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23688.Jul 10 2014, 3:30 AM

joshuaspence retitled this revision from to Fix duplicated "Done" output.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 10 2014, 3:30 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1600: Diff 23688.Jul 10 2014, 3:31 AM

epriestley accepted this revision.Jul 10 2014, 11:41 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 10 2014, 11:41 AM

Closed by commit rPHUa1d23b911a3d (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

moduleutils/

PhutilLibraryMapBuilder.php

1 line

Diff 23692

src/moduleutils/PhutilLibraryMapBuilder.php

Loading...