Page MenuHomePhabricator

Minor change to `ArcanistPhutilLibraryLinter`
ClosedPublic

Authored by joshuaspence on Jul 9 2014, 9:19 PM.

Details

Summary

Ref T5577. Modify ArcanistPhutilLibraryLinter to use PhutilLibraryMapBuilder instead of using an ExecFuture to run phutil_rebuild_map.php.

Test Plan

Ran arc lint.

Diff Detail

Repository
rARC Arcanist
Branch
phutillint
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 1591
Build 1592: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

Excuse: Why is this failing? Hmm, this is unrelated.
TimeTest
0 mstestXMLLint
0 mstestCSSLintLinter
0 mstestClosureLinter
0 mstestCoffeeLintLinter
0 mstestFixLetterCase
View Full Test Results (1 Failed · 20 Passed · 4 Skipped)

Event Timeline

joshuaspence retitled this revision from to Minor change to `ArcanistPhutilLibraryLinter`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/ArcanistPhutilLibraryLinter.php
61

Now unused?

This revision is now accepted and ready to land.Jul 9 2014, 9:35 PM