Page MenuHomePhabricator
Differential D9856

Remove `@group` annotations
ClosedPublic
Actions

Authored by joshuaspence on Jul 8 2014, 10:57 PM.
Tags
None
Referenced Files
F18088696: D9856.id23676.diff
Wed, Aug 6, 9:00 AM
F18086425: D9856.diff
Tue, Aug 5, 9:48 PM
F17946336: D9856.id23676.diff
Thu, Jul 31, 2:14 PM
F17919502: D9856.id23676.largetrue.diff
Wed, Jul 30, 2:37 AM
F17909212: D9856.largetrue.diff
Tue, Jul 29, 2:15 PM
F17861430: D9856.id23649.diff
Sun, Jul 27, 10:48 PM
F17836221: D9856.diff
Sat, Jul 26, 3:55 PM
Unknown Object (File)
Jun 29 2025, 2:04 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUed335c485c0a: Remove `@group` annotations
Summary

I'm pretty sure that @group annotations are useless now... see D9855.

Test Plan

Eye-ball it.

Diff Detail

Repository
rPHU libphutil
Branch
rm_group
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:133XHP45PHP Compatibility
Errorsrc/filesystem/Filesystem.php:558XHP45PHP Compatibility
Errorsrc/future/http/HTTPSFuture.php:533XHP45PHP Compatibility
Advicesrc/future/exec/ExecFuture.php:167XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 1579
Build 1580: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23649.Jul 8 2014, 10:57 PM
joshuaspence retitled this revision from to Remove `@group` annotations.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2014, 10:57 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1579: Diff 23649.Jul 8 2014, 10:58 PM
epriestley accepted this revision.Jul 9 2014, 10:01 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 10:01 PM
joshuaspence closed this revision.Jul 9 2014, 10:08 PM
joshuaspence updated this revision to Diff 23676.

Closed by commit rPHUed335c485c0a (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
3 lines
aphront/
storage/
connection/
4 lines
2 lines
3 lines
mysql/
3 lines
3 lines
2 lines
exception/
5 lines
5 lines
5 lines
5 lines
5 lines
7 lines
3 lines
7 lines
5 lines
3 lines
8 lines
7 lines
writeguard/
3 lines
3 lines
event/
3 lines
cache/
1 line
2 lines
1 line
2 lines
1 line
1 line
1 line
channel/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
conduit/
3 lines
3 lines
3 lines
console/
1 line
3 lines
3 lines
3 lines
4 lines
2 lines
__tests__/
4 lines
16 lines
daemon/
1 line
2 lines
torture/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
6 lines
error/
1 line
1 line
1 line
2 lines
events/
1 line
3 lines
1 line
constant/
7 lines
1 line
filesystem/
1 line
1 line
1 line
2 lines
1 line
3 lines
3 lines
2 lines
2 lines
__tests__/
38 lines
6 lines
4 lines
10 lines
linesofalarge/
2 lines
7 lines
2 lines
__tests__/
3 lines
3 lines
future/
22 lines
2 lines
5 lines
2 lines
__tests__/
3 lines
asana/
3 lines
aws/
3 lines
3 lines
3 lines
3 lines
exec/
1 line
12 lines
2 lines
__tests__/
8 lines
10 lines
1 line
http/
8 lines
14 lines
4 lines
status/
3 lines
3 lines
3 lines
3 lines
3 lines
paypal/
3 lines
twitch/
3 lines
internationalization/
4 lines
4 lines
__tests__/
2 lines
4 lines
3 lines
4 lines
lexer/
2 lines
4 lines
6 lines
3 lines
3 lines
3 lines
markup/
6 lines
__tests__/
28 lines
3 lines
engine/
__tests__/
2 lines
remarkup/
2 lines
blockrule/
1 line
1 line
3 lines
3 lines
3 lines
4 lines
3 lines
4 lines
12 lines
4 lines
3 lines
3 lines
3 lines
3 lines
markuprule/
2 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
27 lines
syntax/
engine/
6 lines
4 lines
__tests__/
2 lines
highlighter/
3 lines
4 lines
3 lines
4 lines
3 lines
3 lines
3 lines
3 lines
6 lines
3 lines
__tests__/
3 lines
3 lines
pygments/
3 lines
xhpast/
3 lines
moduleutils/
3 lines
3 lines
2 lines
9 lines
parser/
4 lines
__tests__/
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
2 lines
aast/
api/
24 lines
3 lines
4 lines
4 lines
argument/
2 lines
3 lines
__tests__/
3 lines
3 lines
exception/
7 lines
7 lines
7 lines
workflow/
1 line
3 lines
xhpast/
api/
3 lines
3 lines
3 lines
3 lines
__tests__/
4 lines
readableserializer/
9 lines
symbols/
5 lines
exception/
5 lines
utils/
2 lines
__tests__/
4 lines
3 lines
2 lines
4 lines
5 lines
7 lines
64 lines
3 lines
29 lines
57 lines
xsprintf/
3 lines
5 lines
4 lines
6 lines
1 line
15 lines
21 lines
1 line

Diff 23649

View Options

src/__phutil_library_init__.php

Loading...
View Options

src/aphront/storage/connection/AphrontDatabaseConnection.php

Loading...
View Options

src/aphront/storage/connection/AphrontDatabaseTransactionState.php

Loading...
View Options

src/aphront/storage/connection/AphrontIsolatedDatabaseConnection.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnectionBase.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryAccessDeniedException.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryConnectionException.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryConnectionLostException.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryCountException.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryDeadlockException.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryDuplicateKeyException.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryException.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryNotSupportedException.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryObjectMissingException.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryParameterException.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryRecoverableException.php

Loading...
View Options

src/aphront/storage/exception/AphrontQuerySchemaException.php

Loading...
View Options

src/aphront/writeguard/AphrontScopedUnguardedWriteCapability.php

Loading...
View Options

src/aphront/writeguard/AphrontWriteGuard.php

Loading...
View Options

src/aphront/writeguard/event/AphrontWriteGuardExitEventListener.php

Loading...
View Options

src/cache/PhutilKeyValueCache.php

Loading...
View Options

src/cache/PhutilKeyValueCacheAPC.php

Loading...
View Options

src/cache/PhutilKeyValueCacheDirectory.php

Loading...
View Options

src/cache/PhutilKeyValueCacheInRequest.php

Loading...
View Options

src/cache/PhutilKeyValueCacheMemcache.php

Loading...
View Options

src/cache/PhutilKeyValueCacheOnDisk.php

Loading...
View Options

src/cache/PhutilKeyValueCacheStack.php

Loading...
View Options

src/channel/PhutilChannel.php

Loading...
View Options

src/channel/PhutilChannelChannel.php

Loading...
View Options

src/channel/PhutilExecChannel.php

Loading...
View Options

src/channel/PhutilMetricsChannel.php

Loading...
View Options

src/channel/PhutilProtocolChannel.php

Loading...
View Options

src/channel/PhutilSocketChannel.php

Loading...
View Options

src/conduit/ConduitClient.php

Loading...
View Options

src/conduit/ConduitClientException.php

Loading...
View Options

src/conduit/ConduitFuture.php

Loading...
View Options

src/console/PhutilConsole.php

Loading...
View Options

src/console/PhutilConsoleFormatter.php

Loading...
View Options

src/console/PhutilConsoleServer.php

Loading...
View Options

src/console/PhutilConsoleServerChannel.php

Loading...
View Options

src/console/PhutilConsoleStdinNotInteractiveException.php

Loading...
View Options

src/console/PhutilInteractiveEditor.php

Loading...
View Options

src/console/__tests__/PhutilConsoleWrapTestCase.php

Loading...
View Options

src/console/format.php

Loading...
View Options

src/daemon/PhutilDaemon.php

Loading...
View Options

src/daemon/PhutilDaemonOverseer.php

Loading...
View Options

src/daemon/torture/PhutilExcessiveServiceCallsDaemon.php

Loading...
View Options

src/daemon/torture/PhutilFatalDaemon.php

Loading...
View Options

src/daemon/torture/PhutilHangForeverDaemon.php

Loading...
View Options

src/daemon/torture/PhutilNiceDaemon.php

Loading...
View Options

src/daemon/torture/PhutilProcessGroupDaemon.php

Loading...
View Options

src/daemon/torture/PhutilSaturateStdoutDaemon.php

Loading...
View Options

src/daemon/torture/PhutilTortureTestDaemon.php

Loading...
View Options

src/error/PhutilAggregateException.php

Loading...
View Options

src/error/PhutilErrorHandler.php

Loading...
View Options

src/error/PhutilProxyException.php

Loading...
View Options

src/error/phlog.php

Loading...
View Options

src/events/PhutilEvent.php

Loading...
View Options

src/events/PhutilEventEngine.php

Loading...
View Options

src/events/PhutilEventListener.php

Loading...
View Options

src/events/constant/PhutilEventConstants.php

Loading...
View Options

src/events/constant/PhutilEventType.php

Loading...
View Options

src/filesystem/FileFinder.php

Loading...
View Options

src/filesystem/FileList.php

Loading...
View Options

src/filesystem/Filesystem.php

Loading...
View Options

src/filesystem/FilesystemException.php

Loading...
View Options

src/filesystem/PhutilDeferredLog.php

Loading...
View Options

src/filesystem/PhutilDirectoryFixture.php

Loading...
View Options

src/filesystem/PhutilFileLock.php

Loading...
View Options

src/filesystem/PhutilLock.php

Loading...
View Options

src/filesystem/TempFile.php

Loading...
View Options

src/filesystem/__tests__/FileFinderTestCase.php

Loading...
View Options

src/filesystem/__tests__/FilesystemTestCase.php

Loading...
View Options

src/filesystem/__tests__/PhutilDeferredLogTestCase.php

Loading...
View Options

src/filesystem/__tests__/PhutilFileLockTestCase.php

Loading...
View Options

src/filesystem/linesofalarge/LinesOfALarge.php

Loading...
View Options

src/filesystem/linesofalarge/LinesOfALargeExecFuture.php

Loading...
View Options

src/filesystem/linesofalarge/LinesOfALargeFile.php

Loading...
View Options

src/filesystem/linesofalarge/__tests__/LinesOfALargeExecFutureTestCase.php

Loading...
View Options

src/filesystem/linesofalarge/__tests__/LinesOfALargeFileTestCase.php

Loading...
View Options

src/future/Future.php

Loading...
View Options

src/future/FutureIterator.php

Loading...
View Options

src/future/FutureProxy.php

Loading...
View Options

src/future/ImmediateFuture.php

Loading...
View Options

src/future/__tests__/FutureIteratorTestCase.php

Loading...
View Options

src/future/asana/PhutilAsanaFuture.php

Loading...
View Options

src/future/aws/PhutilAWSEC2Future.php

Loading...
View Options

src/future/aws/PhutilAWSException.php

Loading...
View Options

src/future/aws/PhutilAWSFuture.php

Loading...
View Options

src/future/aws/PhutilAWSS3Future.php

Loading...
View Options

src/future/exec/CommandException.php

Loading...
View Options

src/future/exec/ExecFuture.php

Loading...
View Options

src/future/exec/PhutilExecPassthru.php

Loading...
View Options

src/future/exec/__tests__/ExecFutureTestCase.php

Loading...
View Options

src/future/exec/execx.php

Loading...
View Options

src/future/functions.php

Loading...
View Options

src/future/http/BaseHTTPFuture.php

Loading...
View Options

src/future/http/HTTPFuture.php

Loading...
View Options

src/future/http/HTTPSFuture.php

Loading...
View Options

src/future/http/status/HTTPFutureResponseStatus.php

Loading...
View Options

src/future/http/status/HTTPFutureResponseStatusCURL.php

Loading...
View Options

src/future/http/status/HTTPFutureResponseStatusHTTP.php

Loading...
View Options

src/future/http/status/HTTPFutureResponseStatusParse.php

Loading...
View Options

src/future/http/status/HTTPFutureResponseStatusTransport.php

Loading...
View Options

src/future/paypal/PhutilPayPalAPIFuture.php

Loading...
View Options

src/future/twitch/PhutilTwitchFuture.php

Loading...
View Options

src/internationalization/PhutilPerson.php

Loading...
View Options

src/internationalization/PhutilTranslator.php

Loading...
View Options

src/internationalization/__tests__/PhutilPHTTestCase.php

Loading...
View Options

src/internationalization/__tests__/PhutilPersonTest.php

Loading...
View Options

src/internationalization/__tests__/PhutilTranslatorTestCase.php

Loading...
View Options

src/internationalization/pht.php

Loading...
View Options

src/lexer/PhutilLexer.php

Loading...
View Options

src/lexer/PhutilPHPFragmentLexer.php

Loading...
View Options

src/lexer/PhutilPythonFragmentLexer.php

Loading...
View Options

src/lexer/PhutilShellLexer.php

Loading...
View Options

src/lexer/PhutilSimpleOptionsLexer.php

Loading...
View Options

src/lexer/PhutilTypeLexer.php

Loading...
View Options

src/markup/PhutilMarkupEngine.php

Loading...
View Options

src/markup/__tests__/PhutilMarkupTestCase.php

Loading...
View Options

src/markup/__tests__/PhutilSafeHTMLTestCase.php

Loading...
View Options

src/markup/engine/__tests__/PhutilRemarkupEngineTestCase.php

Loading...
View Options

src/markup/engine/remarkup/PhutilRemarkupBlockStorage.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupCodeBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupDefaultBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupHeaderBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupHorizontalRuleBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupInlineBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupInterpreterRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupListBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupLiteralBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupNoteBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupSimpleTableBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupTableBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupTestInterpreterRule.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRule.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleBold.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleDel.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleDocumentLink.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleEscapeRemarkup.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleHyperlink.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleItalic.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleLinebreaks.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleMonospace.php

Loading...
View Options

src/markup/render.php

Loading...
View Options

src/markup/syntax/engine/PhutilDefaultSyntaxHighlighterEngine.php

Loading...
View Options

src/markup/syntax/engine/PhutilSyntaxHighlighterEngine.php

Loading...
View Options

src/markup/syntax/engine/__tests__/PhutilDefaultSyntaxHighlighterEngineTestCase.php

Loading...
View Options

src/markup/syntax/highlighter/PhutilConsoleSyntaxHighlighter.php

Loading...
View Options

src/markup/syntax/highlighter/PhutilDefaultSyntaxHighlighter.php

Loading...
View Options

src/markup/syntax/highlighter/PhutilDivinerSyntaxHighlighter.php

Loading...
View Options

src/markup/syntax/highlighter/PhutilInvisibleSyntaxHighlighter.php

Loading...
View Options

src/markup/syntax/highlighter/PhutilLexerSyntaxHighlighter.php

Loading...
View Options

src/markup/syntax/highlighter/PhutilPygmentsSyntaxHighlighter.php

Loading...
View Options

src/markup/syntax/highlighter/PhutilRainbowSyntaxHighlighter.php

Loading...
View Options

src/markup/syntax/highlighter/PhutilSyntaxHighlighter.php

Loading...
View Options

src/markup/syntax/highlighter/PhutilSyntaxHighlighterException.php

Loading...
View Options

src/markup/syntax/highlighter/PhutilXHPASTSyntaxHighlighter.php

Loading...
View Options

src/markup/syntax/highlighter/__tests__/PhutilPHPFragmentLexerHighlighterTestCase.php

Loading...
View Options

src/markup/syntax/highlighter/__tests__/PhutilXHPASTSyntaxHighlighterTestCase.php

Loading...
View Options

src/markup/syntax/highlighter/pygments/PhutilDefaultSyntaxHighlighterEnginePygmentsFuture.php

Loading...
View Options

src/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php

Loading...
View Options

src/moduleutils/PhutilBootloader.php

Loading...
View Options

src/moduleutils/PhutilBootloaderException.php

Loading...
View Options

src/moduleutils/PhutilLibraryConflictException.php

Loading...
View Options

src/moduleutils/core.php

Loading...
View Options

src/parser/PhutilDocblockParser.php

Loading...
View Options

src/parser/__tests__/PhutilDocblockParserTestCase.php

Loading...
View Options

src/parser/__tests__/PhutilEmailAddressTestCase.php

Loading...
View Options

src/parser/__tests__/PhutilJSONTestCase.php

Loading...
View Options

src/parser/__tests__/PhutilLanguageGuesserTestCase.php

Loading...
View Options

src/parser/__tests__/PhutilQueryStringParserTestCase.php

Loading...
View Options

src/parser/__tests__/PhutilSimpleOptionsTestCase.php

Loading...
View Options

src/parser/__tests__/PhutilURITestCase.php

Loading...
View Options

src/parser/aast/api/AASTNode.php

Loading...
View Options

src/parser/aast/api/AASTNodeList.php

Loading...
View Options

src/parser/aast/api/AASTToken.php

Loading...
View Options

src/parser/aast/api/AASTTree.php

Loading...
View Options

src/parser/argument/PhutilArgumentParser.php

Loading...
View Options

src/parser/argument/PhutilArgumentSpecification.php

Loading...
View Options

src/parser/argument/__tests__/PhutilArgumentParserTestCase.php

Loading...
View Options

src/parser/argument/__tests__/PhutilArgumentSpecificationTestCase.php

Loading...
View Options

src/parser/argument/exception/PhutilArgumentParserException.php

Loading...
View Options

src/parser/argument/exception/PhutilArgumentSpecificationException.php

Loading...
View Options

src/parser/argument/exception/PhutilArgumentUsageException.php

Loading...
View Options

src/parser/argument/workflow/PhutilArgumentWorkflow.php

Loading...
View Options

src/parser/argument/workflow/PhutilHelpArgumentWorkflow.php

Loading...
View Options

src/parser/xhpast/api/XHPASTNode.php

Loading...
View Options

src/parser/xhpast/api/XHPASTSyntaxErrorException.php

Loading...
View Options

src/parser/xhpast/api/XHPASTToken.php

Loading...
View Options

src/parser/xhpast/api/XHPASTTree.php

Loading...
View Options

src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php

Loading...
View Options

src/readableserializer/PhutilReadableSerializer.php

Loading...
View Options

src/symbols/PhutilSymbolLoader.php

Loading...
View Options

src/symbols/exception/PhutilMissingSymbolException.php

Loading...
View Options

src/utils/PhutilUTF8StringTruncator.php

Loading...
View Options

src/utils/__tests__/AbstractDirectedGraphTestCase.php

Loading...
View Options

src/utils/__tests__/MFilterTestHelper.php

Loading...
View Options

src/utils/__tests__/PhutilArrayTestCase.php

Loading...
View Options

src/utils/__tests__/PhutilBufferedIteratorTestCase.php

Loading...
View Options

src/utils/__tests__/PhutilChunkedIteratorTestCase.php

Loading...
View Options

src/utils/__tests__/PhutilUTF8TestCase.php

Loading...
View Options

src/utils/__tests__/PhutilUtilsTestCase.php

Loading...
View Options

src/utils/__tests__/TestAbstractDirectedGraph.php

Loading...
View Options

src/utils/utf8.php

Loading...
View Options

src/utils/utils.php

Loading...
View Options

src/xsprintf/PhutilQsprintfInterface.php

Loading...
View Options

src/xsprintf/csprintf.php

Loading...
View Options

src/xsprintf/hgsprintf.php

Loading...
View Options

src/xsprintf/jsprintf.php

Loading...
View Options

src/xsprintf/ldapsprintf.php

Loading...
View Options

src/xsprintf/qsprintf.php

Loading...
View Options

src/xsprintf/queryfx.php

Loading...
View Options

src/xsprintf/urisprintf.php

Loading...
Phabricator · Built by Phacility