Minor change to `PhutilInfrastructureTestCase::testLibraryMap`
ClosedPublic
Actions

Authored by joshuaspence on Jul 6 2014, 4:50 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUf797b98e00bf: Minor change to `PhutilInfrastructureTestCase::testLibraryMap`

Summary

Modify PhutilInfrastructureTestCase::testLibraryMap to use phutil_get_current_library_name() instead of hard-coding the library name.

Test Plan

Ran arc unit, tests passed. Added a new function without running arc liberate, tests failed.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23609.Jul 6 2014, 4:50 AM

joshuaspence retitled this revision from to Minor change to `PhutilInfrastructureTestCase::testLibraryMap`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 6 2014, 4:50 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1547: Diff 23609.Jul 6 2014, 4:51 AM

epriestley accepted this revision.Jul 6 2014, 1:24 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 6 2014, 1:24 PM

Closed by commit rPHUf797b98e00bf (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

__tests__/

PhutilInfrastructureTestCase.php

5 lines

Diff 23618

View Options

src/tests/PhutilInfrastructureTestCase.php

Minor change to `PhutilInfrastructureTestCase::testLibraryMap`ClosedPublicActions