Page MenuHomePhabricator
Differential D9842

set localpath in repository.create
ClosedPublic
Actions

Authored by avivey on Jul 5 2014, 10:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 12:43 AM
Unknown Object (File)
Mon, Dec 9, 7:04 AM
Unknown Object (File)
Sun, Dec 8, 10:53 PM
Unknown Object (File)
Thu, Dec 5, 9:47 PM
Unknown Object (File)
Thu, Dec 5, 12:32 PM
Unknown Object (File)
Wed, Dec 4, 8:59 AM
Unknown Object (File)
Wed, Dec 4, 8:59 AM
Unknown Object (File)
Wed, Dec 4, 8:59 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP64e2aad46fa0: set localpath in repository.create
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Since there's no way to set it, it defaults to an empty value. Make the conduit call set up sane default.

Test Plan

Call method, repo get's built with expected localpath.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 1544
Build 1544: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

avivey updated this revision to Diff 23605.Jul 5 2014, 10:48 PM
avivey retitled this revision from to set localpath in repository.create.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 5 2014, 10:48 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1544: Diff 23605.Jul 5 2014, 10:49 PM
avivey added a comment.Jul 5 2014, 10:51 PM

I wanted to put this on the pre-save hook in repository, but found no other uses of that hook.

Anyway, this method needs some updating to support some recent changes like "hosted repositories".

epriestley accepted this revision.Jul 9 2014, 10:35 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jul 9 2014, 10:35 PM
epriestley closed this revision.Jul 9 2014, 10:35 PM
epriestley updated this revision to Diff 23682.

Closed by commit rP64e2aad46fa0 (authored by @avivey, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
conduit/
9 lines

Diff 23605

View Options

src/applications/repository/conduit/ConduitAPI_repository_create_Method.php

Loading...
Phabricator · Built by Phacility