Differential D9842

set localpath in repository.create
ClosedPublic
Actions

Authored by avivey on Jul 5 2014, 10:48 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP64e2aad46fa0: set localpath in repository.create

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Since there's no way to set it, it defaults to an empty value. Make the conduit call set up sane default.

Test Plan

Call method, repo get's built with expected localpath.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avivey updated this revision to Diff 23605.Jul 5 2014, 10:48 PM

avivey retitled this revision from to set localpath in repository.create.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 5 2014, 10:48 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1544: Diff 23605.Jul 5 2014, 10:49 PM

I wanted to put this on the pre-save hook in repository, but found no other uses of that hook.

Anyway, this method needs some updating to support some recent changes like "hosted repositories".

Thanks!

This revision is now accepted and ready to land.Jul 9 2014, 10:35 PM

Closed by commit rP64e2aad46fa0 (authored by @avivey, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

conduit/

ConduitAPI_repository_create_Method.php

9 lines

Diff 23682

View Options

src/applications/repository/conduit/ConduitAPI_repository_create_Method.php

set localpath in repository.createClosedPublicActions