Paths

Table of Contentst

Differential D9828

Add a `phutil_get_current_library_name` function
ClosedPublic
Actions

Authored by joshuaspence on Jul 5 2014, 4:07 PM.

Tags

None

Referenced Files

	F13257647: D9828.id.diff
	Sun, May 26, 3:29 AM

	F13253899: D9828.diff
	Sat, May 25, 3:01 AM

	F13233625: D9828.diff
	Tue, May 21, 2:27 AM

	F13219322: D9828.id23608.diff
	Sat, May 18, 5:23 PM

	F13211780: D9828.diff
	Fri, May 17, 6:05 AM

	F13197254: D9828.diff
	Sun, May 12, 11:57 PM

	Unknown Object (File)
	Mon, May 6, 3:35 PM

	Unknown Object (File)
	Mon, May 6, 3:35 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU9f20c53e8cbf: Add a `phutil_get_current_library_name` function

Summary

See https://secure.phabricator.com/D9827?id=23585#inline-37952

Test Plan

Called the function from within arcanist and verified that 'arcanist' was returned.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23588.Jul 5 2014, 4:07 PM

joshuaspence retitled this revision from to Add a `phutil_get_current_library_name` function.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 5 2014, 4:07 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1529: Diff 23588.Jul 5 2014, 4:08 PM

epriestley accepted this revision.Jul 5 2014, 4:09 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 5 2014, 4:09 PM

Use head instead of idx(..., 0)
Pass false to debug_backtrace, because we don't need DEBUG_BACKTRACE_PROVIDE_OBJECT.
Add a very basic unit test

Harbormaster completed remote builds in B1546: Diff 23607.Jul 6 2014, 4:43 AM

Closed by commit rPHU9f20c53e8cbf (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

3 lines

moduleutils/

__tests__/

PhutilModuleUtilsTestCase.php

9 lines

moduleutils.php

7 lines

Diff 23608

src/__phutil_library_map__.php

Loading...

src/moduleutils/tests/PhutilModuleUtilsTestCase.php

Loading...

src/moduleutils/moduleutils.php

Loading...