Page MenuHomePhabricator
Differential D9828

Add a `phutil_get_current_library_name` function
ClosedPublic
Actions

Authored by joshuaspence on Jul 5 2014, 4:07 PM.
Tags
None
Referenced Files
F14009322: D9828.id23588.diff
Wed, Oct 30, 2:29 PM
F14009321: D9828.id23608.diff
Wed, Oct 30, 2:28 PM
F14009320: D9828.id23607.diff
Wed, Oct 30, 2:28 PM
F14009318: D9828.id.diff
Wed, Oct 30, 2:27 PM
F14009292: D9828.diff
Wed, Oct 30, 2:15 PM
F13995169: D9828.id23588.diff
Wed, Oct 23, 11:05 AM
F13963649: D9828.id23608.diff
Tue, Oct 15, 5:07 PM
Unknown Object (File)
Wed, Oct 9, 6:23 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU9f20c53e8cbf: Add a `phutil_get_current_library_name` function
Summary

See https://secure.phabricator.com/D9827?id=23585#inline-37952

Test Plan

Called the function from within arcanist and verified that 'arcanist' was returned.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23588.Jul 5 2014, 4:07 PM
joshuaspence retitled this revision from to Add a `phutil_get_current_library_name` function.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 5 2014, 4:07 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1529: Diff 23588.Jul 5 2014, 4:08 PM
epriestley accepted this revision.Jul 5 2014, 4:09 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 5 2014, 4:09 PM
joshuaspence updated this revision to Diff 23607.Jul 6 2014, 4:42 AM
joshuaspence edited edge metadata.
  • Use head instead of idx(..., 0)
  • Pass false to debug_backtrace, because we don't need DEBUG_BACKTRACE_PROVIDE_OBJECT.
  • Add a very basic unit test
Harbormaster completed remote builds in B1546: Diff 23607.Jul 6 2014, 4:43 AM
joshuaspence closed this revision.Jul 6 2014, 4:44 AM
joshuaspence updated this revision to Diff 23608.

Closed by commit rPHU9f20c53e8cbf (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
3 lines
moduleutils/
__tests__/
9 lines
7 lines

Diff 23608

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/moduleutils/__tests__/PhutilModuleUtilsTestCase.php

Loading...
View Options

src/moduleutils/moduleutils.php

Loading...
Phabricator · Built by Phacility