Page MenuHomePhabricator

Improve the `PhabricatorInfrastructureTestCase` unit tests
ClosedPublic

Authored by joshuaspence on Jul 5 2014, 3:23 PM.
Tags
None
Referenced Files
F18377451: D9827.diff
Thu, Aug 28, 1:01 PM
F18376681: D9827.id23585.diff
Thu, Aug 28, 11:37 AM
F18373536: D9827.diff
Thu, Aug 28, 7:42 AM
F18349553: D9827.diff
Tue, Aug 26, 6:25 PM
F17731759: D9827.id23585.diff
Jul 20 2025, 2:40 AM
F17728312: D9827.diff
Jul 19 2025, 2:23 PM
Unknown Object (File)
Jun 9 2025, 2:31 AM
Unknown Object (File)
Apr 8 2025, 7:23 AM
Subscribers

Details

Summary

Improve the PhabricatorInfrastructureTestCase unit tests such that they will fail if any of the following conditions are satisfied:

  • A symbol referenced in the __phutil_library_map__.php file no longer exists.
  • A symbol exists in the library but is not referenced within the __phutil_library_map__.php file.
  • A symbol extends from a different parent symbol than that declared in the __phutil_library_map.php file.
Test Plan

See D9824.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Improve the `PhabricatorInfrastructureTestCase` unit tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 5 2014, 3:25 PM
src/__tests__/PhabricatorInfrastructureTestCase.php
26

Is there a phutil_get_current_library() method, which would be a little nicer?

joshuaspence updated this revision to Diff 23586.

Closed by commit rP8fa1708940c6 (authored by @joshuaspence).