Page MenuHomePhabricator

Improve the `PhabricatorInfrastructureTestCase` unit tests
ClosedPublic

Authored by joshuaspence on Jul 5 2014, 3:23 PM.
Tags
None
Referenced Files
F15466996: D9827.diff
Thu, Apr 3, 11:33 AM
F15431603: D9827.id23586.diff
Mon, Mar 24, 1:23 PM
F15416169: D9827.diff
Thu, Mar 20, 9:43 AM
F15413107: D9827.id23586.diff
Wed, Mar 19, 5:02 PM
F15412934: D9827.id23585.diff
Wed, Mar 19, 3:52 PM
F15412324: D9827.id23585.diff
Wed, Mar 19, 12:28 PM
F15411937: D9827.id.diff
Wed, Mar 19, 10:26 AM
F15411849: D9827.id23586.diff
Wed, Mar 19, 10:02 AM
Subscribers

Details

Summary

Improve the PhabricatorInfrastructureTestCase unit tests such that they will fail if any of the following conditions are satisfied:

  • A symbol referenced in the __phutil_library_map__.php file no longer exists.
  • A symbol exists in the library but is not referenced within the __phutil_library_map__.php file.
  • A symbol extends from a different parent symbol than that declared in the __phutil_library_map.php file.
Test Plan

See D9824.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Improve the `PhabricatorInfrastructureTestCase` unit tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 5 2014, 3:25 PM
src/__tests__/PhabricatorInfrastructureTestCase.php
26

Is there a phutil_get_current_library() method, which would be a little nicer?

joshuaspence updated this revision to Diff 23586.

Closed by commit rP8fa1708940c6 (authored by @joshuaspence).