Page MenuHomePhabricator

Improve the `PhabricatorInfrastructureTestCase` unit tests
ClosedPublic

Authored by joshuaspence on Jul 5 2014, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:04 PM
Unknown Object (File)
Fri, Dec 20, 6:26 AM
Unknown Object (File)
Tue, Dec 17, 8:25 PM
Unknown Object (File)
Sat, Dec 14, 6:08 PM
Unknown Object (File)
Sat, Dec 7, 4:41 PM
Unknown Object (File)
Fri, Dec 6, 9:37 PM
Unknown Object (File)
Wed, Dec 4, 10:32 PM
Unknown Object (File)
Tue, Dec 3, 11:29 PM
Subscribers

Details

Summary

Improve the PhabricatorInfrastructureTestCase unit tests such that they will fail if any of the following conditions are satisfied:

  • A symbol referenced in the __phutil_library_map__.php file no longer exists.
  • A symbol exists in the library but is not referenced within the __phutil_library_map__.php file.
  • A symbol extends from a different parent symbol than that declared in the __phutil_library_map.php file.
Test Plan

See D9824.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Improve the `PhabricatorInfrastructureTestCase` unit tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 5 2014, 3:25 PM
src/__tests__/PhabricatorInfrastructureTestCase.php
26

Is there a phutil_get_current_library() method, which would be a little nicer?

joshuaspence updated this revision to Diff 23586.

Closed by commit rP8fa1708940c6 (authored by @joshuaspence).