Page MenuHomePhabricator

Improve the `ArcanistInfrastructureTestCase` unit tests
ClosedPublic

Authored by joshuaspence on Jul 5 2014, 3:21 PM.
Tags
None
Referenced Files
F15502760: D9826.id23583.diff
Mon, Apr 14, 4:00 AM
F15498376: D9826.id23587.diff
Sun, Apr 13, 12:49 PM
F15470195: D9826.id23587.diff
Fri, Apr 4, 9:14 PM
F15468887: D9826.diff
Fri, Apr 4, 7:25 AM
F15426999: D9826.id23587.diff
Mar 23 2025, 12:12 PM
F15421139: D9826.id23583.diff
Mar 21 2025, 9:15 PM
F15409363: D9826.id23587.diff
Mar 19 2025, 4:26 AM
F15388135: D9826.id23583.diff
Mar 15 2025, 3:21 AM
Subscribers

Details

Summary

Improve the ArcanistInfrastructureTestCase unit tests such that they will fail if any of the following conditions are satisfied:

  • A symbol referenced in the __phutil_library_map__.php file no longer exists.
  • A symbol exists in the library but is not referenced within the __phutil_library_map__.php file.
  • A symbol extends from a different parent symbol than that declared in the __phutil_library_map.php file.
Test Plan

See D9824

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Improve the `ArcanistInfrastructureTestCase` unit tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 5 2014, 3:25 PM