Page MenuHomePhabricator

Improve the `ArcanistInfrastructureTestCase` unit tests
ClosedPublic

Authored by joshuaspence on Jul 5 2014, 3:21 PM.
Tags
None
Referenced Files
F13993550: D9826.id23583.diff
Tue, Oct 22, 11:38 PM
F13984151: D9826.diff
Sun, Oct 20, 11:18 AM
F13968580: D9826.id.diff
Wed, Oct 16, 10:06 PM
Unknown Object (File)
Sat, Oct 12, 6:37 AM
Unknown Object (File)
Oct 7 2024, 3:35 PM
Unknown Object (File)
Sep 12 2024, 3:33 PM
Unknown Object (File)
Sep 12 2024, 3:32 PM
Unknown Object (File)
Sep 12 2024, 3:31 PM
Subscribers

Details

Summary

Improve the ArcanistInfrastructureTestCase unit tests such that they will fail if any of the following conditions are satisfied:

  • A symbol referenced in the __phutil_library_map__.php file no longer exists.
  • A symbol exists in the library but is not referenced within the __phutil_library_map__.php file.
  • A symbol extends from a different parent symbol than that declared in the __phutil_library_map.php file.
Test Plan

See D9824

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Improve the `ArcanistInfrastructureTestCase` unit tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 5 2014, 3:25 PM