Page MenuHomePhabricator
Differential D9779

Allow dashboard panels to be archived
ClosedPublic
Actions

Authored by epriestley on Jun 29 2014, 4:59 PM.
Tags
None
Referenced Files
F13220790: D9779.diff
Sun, May 19, 1:56 AM
F13208299: D9779.id23476.diff
Thu, May 16, 1:14 PM
F13202796: D9779.diff
Tue, May 14, 11:08 PM
F13186925: D9779.diff
Sat, May 11, 4:13 AM
Unknown Object (File)
Tue, May 7, 5:55 AM
Unknown Object (File)
Fri, May 3, 4:38 AM
Unknown Object (File)
Mon, Apr 29, 3:43 PM
Unknown Object (File)
Mon, Apr 29, 6:30 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T5471: Allow `bin/remove destroy` destroy dashboards and panels
Commits
Restricted Diffusion Commit
rPc9366acbecca: Allow dashboard panels to be archived
Summary

Ref T5471. Adds an archived state for panels. Archived panels don't show up in the default query view or in the "Add Existing Panel" workflow.

Test Plan
  • Archived a panel.
  • Activated a panel.
  • Viewed / searched for archived/active panels.
  • Popped "Add Existing Panel" dropdown and saw it omit archived panels.

Diff Detail

Repository
rP Phabricator
Branch
dash1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1461
Build 1461: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23476.Jun 29 2014, 4:59 PM
epriestley retitled this revision from to Allow dashboard panels to be archived.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5471: Allow `bin/remove destroy` destroy dashboards and panels.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 29 2014, 4:59 PM
epriestley added a comment.Jun 29 2014, 5:00 PM

Screen_Shot_2014-06-29_at_9.54.30_AM.png (983×1 px, 175 KB)

Screen_Shot_2014-06-29_at_9.54.36_AM.png (983×1 px, 133 KB)

Harbormaster completed remote builds in B1460: Diff 23476.Jun 29 2014, 5:01 PM
epriestley updated this revision to Diff 23477.Jun 29 2014, 5:01 PM
  • Also mark the handles as closed.
Harbormaster completed remote builds in B1461: Diff 23477.Jun 29 2014, 5:02 PM
chad accepted this revision.Jul 1 2014, 4:03 PM
chad edited edge metadata.
chad added inline comments.
src/applications/dashboard/customfield/PhabricatorDashboardPanelTabsCustomField.php
34

archived

This revision is now accepted and ready to land.Jul 1 2014, 4:03 PM
epriestley closed this revision.Jul 2 2014, 12:50 AM
epriestley updated this revision to Diff 23503.

Closed by commit rPc9366acbecca (authored by @epriestley).

Revision Contents
Changeset List

Diff 23477

View Options

resources/sql/autopatches/20140629.dasharchive.1.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/dashboard/application/PhabricatorApplicationDashboard.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelArchiveController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php

Loading...
View Options

src/applications/dashboard/customfield/PhabricatorDashboardPanelTabsCustomField.php

Loading...
View Options

src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php

Loading...
View Options

src/applications/dashboard/phid/PhabricatorDashboardPHIDTypePanel.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php

Loading...
Phabricator · Built by Phacility