Page MenuHomePhabricator

Set "max-width: 100%" on "size=full" Remarkup images
ClosedPublic

Authored by epriestley on Jun 27 2014, 5:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 6:58 PM
Unknown Object (File)
Fri, Dec 13, 7:53 PM
Unknown Object (File)
Tue, Dec 3, 3:17 PM
Unknown Object (File)
Tue, Dec 3, 3:17 PM
Unknown Object (File)
Tue, Dec 3, 3:17 PM
Unknown Object (File)
Tue, Dec 3, 3:17 PM
Unknown Object (File)
Tue, Dec 3, 2:57 PM
Unknown Object (File)
Mon, Dec 2, 9:45 PM
Subscribers

Details

Summary

Fixes T5500. When an image is embedded with {Fxx, size=full}, add "max-width: 100%;" so that large images are scaled down to the size of the container. This seems like a better and more reasonable behavior than having them scroll. You can still lightbox them or right-click -> view if you really want the full image.

Test Plan

Dragged window around with a very large size=full image. At large window sizes, the image displayed at 100%. At smaller window sizes, the image was scaled to fit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Set "max-width: 100%" on "size=full" Remarkup images.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2014, 5:27 PM
epriestley updated this revision to Diff 23431.

Closed by commit rP32a42f37feb0 (authored by @epriestley).