Page MenuHomePhabricator

Remove hovercards from Feed panels on dashboards
ClosedPublic

Authored by epriestley on Jun 27 2014, 3:31 PM.
Tags
None
Referenced Files
F14024887: D9753.diff
Thu, Nov 7, 1:07 PM
F13966096: D9753.diff
Wed, Oct 16, 6:08 AM
Unknown Object (File)
Oct 10 2024, 5:39 PM
Unknown Object (File)
Oct 2 2024, 6:07 AM
Unknown Object (File)
Sep 21 2024, 3:13 AM
Unknown Object (File)
Sep 21 2024, 12:46 AM
Unknown Object (File)
Sep 17 2024, 11:56 PM
Unknown Object (File)
Sep 17 2024, 7:40 PM
Subscribers

Details

Summary

Fixes T5472.

I do imagine doing a pass on the Hovercard JS at some point to try to make them position more intelligently (I've hit a few cases where they do something silly, and we can probably fix many of them), but generally agree that this is inconsistent and questionably valuable on panels.

Test Plan
  • Moused over feed stuff in a panel, no hovercards.
  • Moused over feed stuff in Feed, got hovercards.

Diff Detail

Repository
rP Phabricator
Branch
feedhover
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1426
Build 1426: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove hovercards from Feed panels on dashboards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2014, 3:32 PM
epriestley updated this revision to Diff 23420.

Closed by commit rP49d7201873e8 (authored by @epriestley).