Differential D9719

"Hide" columns instead of "Deleting" them
ClosedPublic
Actions

Authored by epriestley on Jun 25 2014, 3:56 AM.

Details

Reviewers

chad

Maniphest Tasks

T5342: Unable to delete workboard column even if empty
T5161: Columns should be able to be "hidden"

Commits

Restricted Diffusion Commit
rPa823d143b404: "Hide" columns instead of "Deleting" them

Summary

Fixes T5342. Fixes T5161. Previously, we were a bit strict about deleting columns because you could orphan tasks. Let users recover these columns more easily so they can't shoot themselves in the foot.

Change "Delete" language to "Hide".
Add a button to let you see hidden columns.
Remove restriction that you can only delete empty columns.

The new button is a little funky, but maybe it merges into the "Add Column" button and that becomes a dropdown with board actions? The rest of this feels OK to me.

Test Plan

See screenshot.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23335.Jun 25 2014, 3:56 AM

epriestley retitled this revision from to "Hide" columns instead of "Deleting" them.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T5161: Columns should be able to be "hidden", T5342: Unable to delete workboard column even if empty.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 25 2014, 3:56 AM

Screen_Shot_2014-06-24_at_8.53.57_PM.png (816×1 px, 93 KB)

Harbormaster completed remote builds in B1375: Diff 23335.Jun 25 2014, 3:57 AM

Yeah I think we're going to want a generic action dropdown so this doesn't become buttontown, population 20.

Yeah, let me get a diff out for that.

I'd probably lean towards enable/disable over show/hide as it seems more clear that you won't be able to do things to it for certain. But I don't feel super strongly, up to you.

This revision is now accepted and ready to land.Jun 25 2014, 7:07 PM

The columns do still work, you just have to show them. There are a couple of other UI things, though:

It would be nice to visually indicate that hidden columns are being shown somehow, but my 2 seconds of poking at it didn't produce anything that felt very good.
The red header for hidden columns isn't great/obvious.
"Hide Hidden Columns" isn't great.

I think I'm going to leave it as-is for now, but probably tweak things soon and/or if users are confused.