Fix Differential DashHeaders
ClosedPublic
Actions

Authored by chad on Jun 24 2014, 9:50 PM.

Tags

None

Referenced Files

	F14061136: D9711.diff
	Mon, Nov 18, 5:23 AM

	F14046858: D9711.diff
	Thu, Nov 14, 12:15 AM

	F14034440: D9711.diff
	Sun, Nov 10, 12:20 AM

	F14004427: D9711.id23318.diff
	Sat, Oct 26, 8:29 PM

	F14004426: D9711.id23320.diff
	Sat, Oct 26, 8:29 PM

	F14004425: D9711.id23319.diff
	Sat, Oct 26, 8:28 PM

	F13969862: D9711.id23319.diff
	Oct 17 2024, 4:15 AM

	F13963116: D9711.id.diff
	Oct 15 2024, 2:04 PM

Subscribers

Tokens

"Love" token, awarded by hach-que.

Details

Reviewers

epriestley

Maniphest Tasks

T5465: Differential workboard panel is not pretty

Commits

Restricted Diffusion Commit
rP320f7689dda0: Fix Differential DashHeaders

Summary

Adds a basic style to ObjectItemList Headers. Fixes T5465

Test Plan

Added the same Query, tested various layouts

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 23318.Jun 24 2014, 9:50 PM

chad retitled this revision from to Fix Differential DashHeaders.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T5465: Differential workboard panel is not pretty.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 24 2014, 9:50 PM

Harbormaster completed remote builds in B1365: Diff 23318.Jun 24 2014, 9:51 PM

Oh there are blank states too. Wonder if it'd be better to break these out into multiple dashboards, piling multiple queries into one panel looks really jank.

More states tested

Harbormaster completed remote builds in B1366: Diff 23319.Jun 24 2014, 9:59 PM

epriestley accepted this revision.Jun 24 2014, 10:09 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 24 2014, 10:09 PM

Closed by commit rP320f7689dda0 (authored by @chad).

suchwow

It's beautiful :D

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

8 lines

webroot/

rsrc/

css/

phui/

phui-object-item-list-view.css

17 lines

Diff 23320

View Options

resources/celerity/map.php