Page MenuHomePhabricator

Show Aphlict connection status in notification menu
ClosedPublic

Authored by epriestley on Jun 23 2014, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 6:31 PM
Unknown Object (File)
Wed, Nov 20, 6:25 PM
Unknown Object (File)
Fri, Nov 15, 11:50 PM
Unknown Object (File)
Mon, Nov 11, 4:39 PM
Unknown Object (File)
Fri, Nov 8, 3:18 PM
Unknown Object (File)
Thu, Oct 31, 4:01 PM
Unknown Object (File)
Oct 21 2024, 10:50 PM
Unknown Object (File)
Oct 6 2024, 1:00 AM
Subscribers

Details

Summary

Fixes T5373. Ref T5281. Several changes:

  • The marshallExceptions thing is useful if JS throws an exception when invoked from Flash, so set it. The resulting exceptions are a little odd (not escaped correctly, e.g.) but way better than nothing.
  • Put connection status in the notification menu.
  • When the connection fails, try to provide contextual help where we can.
Test Plan

Screen_Shot_2014-06-23_at_2.42.25_PM.png (1×1 px, 326 KB)

Diff Detail

Repository
rP Phabricator
Branch
aphlict3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1347
Build 1347: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Show Aphlict connection status in notification menu.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
epriestley edited edge metadata.
  • Slightly cleaner handling of error.text
  • Instead of setting status directly from the master, send it to all of the clients, then set it from there.

Test plan:

  • Opened a master, saw it go through connecting -> error.
  • Opened another window, saw it connect to the master and get the correct status.
This revision is now accepted and ready to land.Jun 23 2014, 10:53 PM
epriestley updated this revision to Diff 23293.

Closed by commit rP76cefde0b3d3 (authored by @epriestley).