Differential D9694

Complain if a Conduit Client doesn't send a host key.
ClosedPublic
Actions

Authored by joshuaspence on Jun 23 2014, 6:11 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP21a259742179: Complain if a Conduit Client doesn't send a host key.

Summary

There is a TODO here that is a few years old... the Conduit Protocol is now at version 7.

Test Plan

One less TODO in the codebase.

Diff Detail

Repository

rP Phabricator

Branch

conduit-validatehost

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1337
Build 1337: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23257.Jun 23 2014, 6:11 PM

joshuaspence retitled this revision from to Complain if a Conduit Client doesn't send a host key..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 23 2014, 6:11 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1337: Diff 23257.Jun 23 2014, 6:12 PM

epriestley accepted this revision.Jun 23 2014, 6:15 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 23 2014, 6:15 PM

Closed by commit rP21a259742179 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

method/

ConduitAPIMethod.php

10 lines

Diff 23257

View Options

src/applications/conduit/method/ConduitAPIMethod.php

Complain if a Conduit Client doesn't send a host key.ClosedPublicActions