Read extension classes and functions from `php_compat_info.json`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 22 2014, 5:54 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC2f3e5e48ef79: Read extension classes and functions from `php_compat_info.json`.

Summary

Consolidate php_extension_classes.txt and php_extension_functions.txt with php_compat_info.json. Given that php_extension_classes.txt and php_extension_functions.txt are manually generated whereas php_compat_info.json is generated automatically, this should make maintenance easier.

Test Plan

Deleted the src/.phutil_module_cache file (in each of rARC, rPHU and rP) and ran arc liberate.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23193.Jun 22 2014, 5:54 PM

joshuaspence retitled this revision from to Read extension classes and functions from `php_compat_info.json`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 22 2014, 5:54 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

joshuaspence added inline comments.Jun 22 2014, 5:55 PM

scripts/phutil_symbols.php
515–518	For some reason, I couldn't use `Filesystem` or `phutil_json_decode` here?

Harbormaster completed remote builds in B1297: Diff 23193.Jun 22 2014, 5:55 PM

joshuaspence added inline comments.Jun 22 2014, 5:56 PM

scripts/phutil_symbols.php
515–520	Do we need interfaces here?

Fix a typo
Prefer single quotes

Harbormaster completed remote builds in B1299: Diff 23195.Jun 22 2014, 5:59 PM

What issue did you run into using that stuff?

scripts/phutil_symbols.php
515–520	Yes, if there are now extension interfaces -- I think when this was written there never were any. It probably should have been generalized anyway, but it would have been a little silly to check in an empty file just for future-proofing.

In D9662#11, @epriestley wrote:

What issue did you run into using that stuff?

I didn't specifically run into any issues with phutil_symbols.php... it just seems nicer to use the existing PHP_CompatInfo data rather than a hand-crafted text file.

Interfaces too

Harbormaster completed remote builds in B1301: Diff 23200.Jun 22 2014, 6:17 PM

Oh, sorry -- I meant this, specifically:

For some reason, I couldn't use Filesystem or phutil_json_decode here?

That is, what issue did you hit doing that? The file uses other libphutil symbols, so it's not immediately obvious to me what the issue was. (That's not related to the hand-crafted files, right? Or am I misunderstanding?)

For testing, I think you can also remove src/.phutil_module_cache from all the libraries and re-liberate them. That won't completely test this stuff, but will at least give you confidence that your modifications can rebuild everything from scratch under at least one configuration -- i.e., your changes didn't completely torpedo everything.

Oh right... I get this:

./scripts/phutil_symbols.php 
PHP Fatal error:  Call to undefined function phutil_json_decode() in /home/joshua/workspace/github.com/phacility/arcanist/scripts/phutil_symbols.php on line 515

In D9662#17, @joshuaspence wrote:

Oh right... I get this:

./scripts/phutil_symbols.php 
PHP Fatal error:  Call to undefined function phutil_json_decode() in /home/joshua/workspace/github.com/phacility/arcanist/scripts/phutil_symbols.php on line 515

Oh right... phutil_symbols_get_builtins() is executed at the very start of the script, before libphutil is loaded.