Ref T5137. Listing the repository in Differential emails makes it easy to filter.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5137: Make emails easier to filter
- Commits
- Restricted Diffusion Commit
rPe0ca39f6a1fa: Show repository in Differential emails
Eye-ball it.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- repo-email
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1208 Build 1208: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
One inline, seems reasonable otherwise.
| src/applications/differential/customfield/DifferentialRepositoryField.php | ||
|---|---|---|
| 155–158 | I think this should use the revision's getRepositoryPHID(), not the latest diff's. | |
Comment Actions
If you really want me to test this properly then I'll give it a shot, but I don't really have outbound mail configured on my dev box.
This comment was removed by • young_hwi.
Comment Actions
Let's do:
$repository->getMonogram().' '.$repository->getName()
...so you get:
REPOSITORY rP Phabricator
This is less ambiguous, more consistent, and should be more routable for rules that can't use headers or whatever.
For your use case, is adding this field only on create/update (like "BRANCH" works, I think) reasonable? I don't have strong feelings either way, but that came to mind as worth mentioning.
(I can handle testing this, so don't worry about that.)
Comment Actions
You can check DifferentialBranchField -- basically if $editor->getDiffUpdateTransaction($xactions) exists.
This comment was removed by zacchiro.
Comment Actions
I posted the comment to the wrong diff (and hence deleted it immediately afterwards). See D18636. Sorry for the noise.