Page MenuHomePhabricator

Convert `arc tasks` to use `PhutilConsoleTable`.
ClosedPublic

Authored by joshuaspence on Jun 17 2014, 4:58 PM.
Tags
None
Referenced Files
F14028060: D9601.diff
Fri, Nov 8, 11:36 AM
F14019031: D9601.id23009.diff
Tue, Nov 5, 9:11 PM
F13973069: D9601.id.diff
Thu, Oct 17, 10:49 PM
F13965991: D9601.id23012.diff
Wed, Oct 16, 5:26 AM
F13960660: D9601.diff
Tue, Oct 15, 12:36 AM
Unknown Object (File)
Sep 20 2024, 5:30 AM
Unknown Object (File)
Sep 20 2024, 3:40 AM
Unknown Object (File)
Sep 17 2024, 3:53 PM
Subscribers

Details

Summary

PhutilConsoleTable does a better job at aligning columns. We still probably need to do some work to PhutilConsoleTable to set a maximum width for a specified column, or elect which columns can be truncated etc but this can probably come later.

Test Plan

`arc_tasks`_with_`PhutilConsoleTable` (345×1 px, 98 KB)

Diff Detail

Repository
rARC Arcanist
Branch
tasks-table
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1180
Build 1180: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Convert `arc tasks` to use `PhutilConsoleTable`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

very nice

This revision is now accepted and ready to land.Jun 17 2014, 5:01 PM