Paths

Table of Contentst

Convert `arc tasks` to use `PhutilConsoleTable`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 17 2014, 4:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 9, 6:07 PM

	Unknown Object (File)
	Fri, Dec 6, 3:29 PM

	Unknown Object (File)
	Thu, Dec 5, 4:19 PM

	Unknown Object (File)
	Tue, Dec 3, 12:59 PM

	Unknown Object (File)
	Mon, Dec 2, 4:02 PM

	Unknown Object (File)
	Mon, Dec 2, 8:35 AM

	Unknown Object (File)
	Sat, Nov 30, 3:49 PM

	Unknown Object (File)
	Tue, Nov 26, 3:19 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC9f8a23d59825: Convert `arc tasks` to use `PhutilConsoleTable`.

Summary

PhutilConsoleTable does a better job at aligning columns. We still probably need to do some work to PhutilConsoleTable to set a maximum width for a specified column, or elect which columns can be truncated etc but this can probably come later.

Test Plan

`arc_tasks`_with_`PhutilConsoleTable` (345×1 px, 98 KB)

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23009.Jun 17 2014, 4:58 PM

joshuaspence retitled this revision from to Convert `arc tasks` to use `PhutilConsoleTable`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2014, 4:58 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1180: Diff 23009.Jun 17 2014, 4:59 PM

very nice

This revision is now accepted and ready to land.Jun 17 2014, 5:01 PM

Closed by commit rARC9f8a23d59825 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistTasksWorkflow.php

102 lines

Diff 23012

View Options

src/workflow/ArcanistTasksWorkflow.php

Convert `arc tasks` to use `PhutilConsoleTable`.ClosedPublicActions