Paths

Table of Contentst

Convert `arc tasks` to use `PhutilConsoleTable`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 17 2014, 4:58 PM.

Tags

None

Referenced Files

	F15460556: D9601.id.diff
	Mon, Mar 31, 11:57 PM

	F15460502: D9601.id23012.diff
	Mon, Mar 31, 11:21 PM

	F15455936: D9601.diff
	Sun, Mar 30, 5:50 AM

	F15442816: D9601.id23012.diff
	Thu, Mar 27, 12:38 AM

	F15418946: D9601.id23012.diff
	Fri, Mar 21, 2:42 AM

	F15412843: D9601.id23009.diff
	Wed, Mar 19, 3:17 PM

	F15397696: D9601.id.diff
	Sun, Mar 16, 9:48 PM

	F15393409: D9601.id23012.diff
	Sat, Mar 15, 8:50 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC9f8a23d59825: Convert `arc tasks` to use `PhutilConsoleTable`.

Summary

PhutilConsoleTable does a better job at aligning columns. We still probably need to do some work to PhutilConsoleTable to set a maximum width for a specified column, or elect which columns can be truncated etc but this can probably come later.

Test Plan

`arc_tasks`_with_`PhutilConsoleTable` (345×1 px, 98 KB)

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23009.Jun 17 2014, 4:58 PM

joshuaspence retitled this revision from to Convert `arc tasks` to use `PhutilConsoleTable`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2014, 4:58 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1180: Diff 23009.Jun 17 2014, 4:59 PM

very nice

This revision is now accepted and ready to land.Jun 17 2014, 5:01 PM

Closed by commit rARC9f8a23d59825 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistTasksWorkflow.php

102 lines

Diff 23012

View Options

src/workflow/ArcanistTasksWorkflow.php

Convert `arc tasks` to use `PhutilConsoleTable`.ClosedPublicActions