Paths

Table of Contentst

Differential D9588

Correctly recognize "no bookmarks" for Mercurial
ClosedPublic
Actions

Authored by richardvanvelzen on Jun 16 2014, 10:53 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5086: "arc feature" and "arc bookmark" do not handle 'no bookmarks' correctly

Commits

rARC3201239e85ea: Correctly recognize "no bookmarks" for Mercurial

Summary

Fixes T5086.

Test Plan

remove all bookmarks and run arc feature

Diff Detail

Repository

rARC Arcanist

Branch

hg-feature

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 1161
Build 1161: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	0 ms	testGitStateParsing
	0 ms	testHgStateParsing
	0 ms	testSVNFileEscapes
	0 ms	testSvnStateParsing

Event Timeline

richardvanvelzen updated this revision to Diff 22979.Jun 16 2014, 10:53 PM

richardvanvelzen retitled this revision from to Correctly recognize "no bookmarks" for Mercurial.

richardvanvelzen updated this object.

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 16 2014, 10:53 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

richardvanvelzen updated this object.Jun 16 2014, 10:54 PM

richardvanvelzen edited edge metadata.

richardvanvelzen added a task: T5086: "arc feature" and "arc bookmark" do not handle 'no bookmarks' correctly.

Harbormaster completed remote builds in B1161: Diff 22979.Jun 16 2014, 10:55 PM

Closed by commit rARC3201239e85ea (authored by @richardvanvelzen, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistMercurialAPI.php

4 lines

Diff 22979

View Options

src/repository/api/ArcanistMercurialAPI.php

Correctly recognize "no bookmarks" for MercurialClosedPublicActions