Let phutil_rebuild_map really be quiet
ClosedPublic
Actions

Authored by richardvanvelzen on Jun 16 2014, 10:48 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC8d7ee9ee38ce: Let phutil_rebuild_map **really** be quiet

Summary

Depends on D9586. The progress bar is written to stderr which results in bad stuff happening when you try run lint (PhutilLibraryLinter calls it)

Test Plan

run arc lint, see no more errors

Diff Detail

Repository

rARC Arcanist

Branch

prog-oops

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1160
Build 1160: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

richardvanvelzen updated this revision to Diff 22977.Jun 16 2014, 10:48 PM

richardvanvelzen retitled this revision from to Let phutil_rebuild_map **really** be quiet.

richardvanvelzen updated this object.

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen added a reviewer: epriestley.

richardvanvelzen added a parent revision: D9586: Allow PhutilConsoleProgressBar to be quiet.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 16 2014, 10:48 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

shhhh

This revision is now accepted and ready to land.Jun 16 2014, 10:48 PM

Harbormaster completed remote builds in B1160: Diff 22977.Jun 16 2014, 10:49 PM

Closed by commit rARC8d7ee9ee38ce (authored by @richardvanvelzen, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

scripts/

lib/

PhutilLibraryMapBuilder.php

3 lines

Diff 22977

View Options

scripts/lib/PhutilLibraryMapBuilder.php

Let phutil_rebuild_map **really** be quietClosedPublicActions