Page MenuHomePhabricator

Use [No Title] on mocks without a title
ClosedPublic

Authored by chad on Jun 16 2014, 4:56 PM.
Tags
None
Referenced Files
F17693196: D9575.id22950.diff
Tue, Jul 15, 6:57 AM
Unknown Object (File)
Jun 7 2025, 8:21 PM
Unknown Object (File)
May 3 2025, 10:37 PM
Unknown Object (File)
Apr 28 2025, 4:38 AM
Unknown Object (File)
Mar 30 2025, 5:55 PM
Unknown Object (File)
Mar 28 2025, 8:15 AM
Unknown Object (File)
Mar 23 2025, 9:39 PM
Unknown Object (File)
Mar 20 2025, 10:16 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP657d061a7897: Use [No Title] on mocks without a title
Summary

For some consistency, older mocks didn't have titles.

Test Plan

visit older mock, buttons are clickable

Diff Detail

Repository
rP Phabricator
Branch
no-title-pholio
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1143
Build 1143: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Use [No Title] on mocks without a title.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

I think we're missing some pht() stuff here but I can counterdiff you.

This revision is now accepted and ready to land.Jun 16 2014, 6:35 PM
chad updated this revision to Diff 22950.

Closed by commit rP657d061a7897 (authored by @chad).