Paths

Table of Contentst

Use [No Title] on mocks without a title
ClosedPublic
Actions

Authored by chad on Jun 16 2014, 4:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 12, 8:53 AM

	Unknown Object (File)
	Wed, Dec 11, 3:27 PM

	Unknown Object (File)
	Tue, Dec 10, 11:20 PM

	Unknown Object (File)
	Fri, Dec 6, 12:53 AM

	Unknown Object (File)
	Tue, Nov 26, 2:12 AM

	Unknown Object (File)
	Nov 18 2024, 8:46 PM

	Unknown Object (File)
	Nov 4 2024, 9:32 AM

	Unknown Object (File)
	Nov 4 2024, 9:27 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP657d061a7897: Use [No Title] on mocks without a title

Summary

For some consistency, older mocks didn't have titles.

Test Plan

visit older mock, buttons are clickable

Diff Detail

Repository

rP Phabricator

Branch

no-title-pholio

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1143
Build 1143: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 22944.Jun 16 2014, 4:56 PM

chad retitled this revision from to Use [No Title] on mocks without a title.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 16 2014, 4:56 PM

Harbormaster completed remote builds in B1143: Diff 22944.Jun 16 2014, 4:57 PM

I think we're missing some pht() stuff here but I can counterdiff you.

This revision is now accepted and ready to land.Jun 16 2014, 6:35 PM

Closed by commit rP657d061a7897 (authored by @chad).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

38 lines

webroot/

rsrc/

js/

application/

pholio/

behavior-pholio-mock-view.js

3 lines

Diff 22944

View Options

resources/celerity/map.php