Paths

Table of Contentst

Use [No Title] on mocks without a title
ClosedPublic
Actions

Authored by chad on Jun 16 2014, 4:56 PM.

Tags

None

Referenced Files

	F13185900: D9575.diff
	Sat, May 11, 3:17 AM

	Unknown Object (File)
	Tue, May 7, 5:29 AM

	Unknown Object (File)
	Fri, May 3, 3:22 AM

	Unknown Object (File)
	Wed, May 1, 6:47 PM

	Unknown Object (File)
	Wed, May 1, 1:09 PM

	Unknown Object (File)
	Wed, May 1, 1:09 PM

	Unknown Object (File)
	Mon, Apr 29, 2:40 PM

	Unknown Object (File)
	Wed, Apr 24, 10:12 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP657d061a7897: Use [No Title] on mocks without a title

Summary

For some consistency, older mocks didn't have titles.

Test Plan

visit older mock, buttons are clickable

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 22944.Jun 16 2014, 4:56 PM

chad retitled this revision from to Use [No Title] on mocks without a title.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 16 2014, 4:56 PM

Harbormaster completed remote builds in B1143: Diff 22944.Jun 16 2014, 4:57 PM

I think we're missing some pht() stuff here but I can counterdiff you.

This revision is now accepted and ready to land.Jun 16 2014, 6:35 PM

Closed by commit rP657d061a7897 (authored by @chad).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

38 lines

webroot/

rsrc/

js/

application/

pholio/

behavior-pholio-mock-view.js

3 lines

Diff 22950

View Options

resources/celerity/map.php