Page MenuHomePhabricator

Make query panels editable by normal humans
ClosedPublic

Authored by epriestley on Jun 16 2014, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2024, 1:27 PM
Unknown Object (File)
Feb 16 2024, 3:52 PM
Unknown Object (File)
Jan 31 2024, 11:51 PM
Unknown Object (File)
Jan 31 2024, 11:51 PM
Unknown Object (File)
Jan 31 2024, 4:24 PM
Unknown Object (File)
Jan 22 2024, 9:54 AM
Unknown Object (File)
Jan 16 2024, 12:27 PM
Unknown Object (File)
Dec 24 2023, 4:23 AM
Subscribers
Tokens
"Yellow Medal" token, awarded by chad.

Details

Summary

Ref T4986. Instead of requiring you to know engine class names and copy/paste URLs, provide select dropdowns that use SCARY JAVASCRIPT to do magical things.

I think this is mostly reasonable, the only issue is that it's hard to create a panel out of a completely ad-hoc query (you'd have to save it, then create a panel out of the saved query, then remove the saved query). Once we develop T5307 we can do a better job of this.

Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Make query panels editable by normal humans.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

What it looks like:

Screen_Shot_2014-06-16_at_8.09.08_AM.png (1×1 px, 213 KB)

The "Query" control dynamically changes based on the value selected in the "Application" control. Wizardry!

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2014, 4:21 PM
epriestley updated this revision to Diff 22955.

Closed by commit rP5aae1ee034ab (authored by @epriestley).