Page MenuHomePhabricator

[Draft] Use Fullscreen API in Pholio
AbandonedPublic

Authored by epriestley on Jun 16 2014, 1:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 10:42 PM
Unknown Object (File)
Tue, Nov 19, 3:50 PM
Unknown Object (File)
Fri, Nov 15, 9:33 AM
Unknown Object (File)
Mon, Nov 11, 6:50 AM
Unknown Object (File)
Thu, Nov 7, 2:59 PM
Unknown Object (File)
Oct 13 2024, 10:35 AM
Unknown Object (File)
Oct 1 2024, 9:52 PM
Unknown Object (File)
Sep 26 2024, 6:23 AM
Subscribers

Details

Summary

Ref T3563. Needs a lot of work. Transitions are particularly messy. See T3563 for discussion.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Branch
fullscreen
Lint
Lint Errors
Unit
No Test Coverage
Build Status
Buildable 1138
Build 1138: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to [Draft] Use Fullscreen API in Pholio.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)

Yeah, this is seemingly not super useful. I'd want (left, right) buttons to work, dialogs to work, and be able to leave additional comments. The new stage is big enough that there isn't too much added benefit here, only maybe on laptops really.

Worth adding the Libs at least if need in future?

The left/right buttons work in Firefox and Safari, but there's some kind of junk in Chrome that kicks you out of fullscreen. I'm not sure if it's use of the history API, or any (uncaptured?) keypress, or what.

The lib is still pretty buggy (e.g., we never actually see the "escape" key, so we don't reset fullscreen mode (I think?), so you can't enter fullscreen twice in a row (in some browsers?)). Generally, there's a lot of weird edge-case behavior to hunt down.

In every browser, the 2-3 second fullscreen animation just kills this for me, at least personally. On OSX, you can also get a sort-of-reasonable (?) alternative by fullscreening the window (Command + Control + F) -- the animation is still really slow and that retains some chrome, but everything still works normally and the animation isn't quite as bad (although, at least on OS X 10.7, the animation is still horribly slow). Apparently there's no way to disable the animation, either.

Yeah I don't see a strong benefit to the work here, personally.

chad requested changes to this revision.Jul 4 2014, 4:16 PM
chad edited edge metadata.

sounds like we're not doing this.

This revision now requires changes to proceed.Jul 4 2014, 4:16 PM
chad removed a reviewer: chad.

Yeah, this didn't seem promising for now. We can revisit it later if use cases or browser implementations change. (I could maybe imagine doing this for something like dashboards or feed where things aren't interactive and you just want "show this thing on a monitor" or something like that.)