Details
- Reviewers
- None
- Maniphest Tasks
- T3563: Consider fullscreen modes for Pholio (and other applications?)
N/A
Diff Detail
- Repository
- rP Phabricator
- Branch
- fullscreen
- Lint
Lint Errors - Unit
No Test Coverage - Build Status
Buildable 1138 Build 1138: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Yeah, this is seemingly not super useful. I'd want (left, right) buttons to work, dialogs to work, and be able to leave additional comments. The new stage is big enough that there isn't too much added benefit here, only maybe on laptops really.
The left/right buttons work in Firefox and Safari, but there's some kind of junk in Chrome that kicks you out of fullscreen. I'm not sure if it's use of the history API, or any (uncaptured?) keypress, or what.
The lib is still pretty buggy (e.g., we never actually see the "escape" key, so we don't reset fullscreen mode (I think?), so you can't enter fullscreen twice in a row (in some browsers?)). Generally, there's a lot of weird edge-case behavior to hunt down.
In every browser, the 2-3 second fullscreen animation just kills this for me, at least personally. On OSX, you can also get a sort-of-reasonable (?) alternative by fullscreening the window (Command + Control + F) -- the animation is still really slow and that retains some chrome, but everything still works normally and the animation isn't quite as bad (although, at least on OS X 10.7, the animation is still horribly slow). Apparently there's no way to disable the animation, either.
Yeah, this didn't seem promising for now. We can revisit it later if use cases or browser implementations change. (I could maybe imagine doing this for something like dashboards or feed where things aren't interactive and you just want "show this thing on a monitor" or something like that.)