Page MenuHomePhabricator
Differential D9565

Add an `ArcanistJscsLinter`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 15 2014, 11:43 PM.
Tags
None
Referenced Files
F14096369: D9565.diff
Tue, Nov 26, 2:54 AM
Unknown Object (File)
Sun, Nov 24, 12:49 AM
Unknown Object (File)
Thu, Nov 21, 2:17 PM
Unknown Object (File)
Wed, Nov 20, 10:45 PM
Unknown Object (File)
Sat, Nov 16, 11:49 AM
Unknown Object (File)
Tue, Nov 12, 1:26 PM
Unknown Object (File)
Sun, Nov 10, 7:27 AM
Unknown Object (File)
Sun, Nov 10, 7:11 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCb1ddd0f03b2a: Add an `ArcanistJscsLinter`.
Summary

Add a linter which wraps around JSCS.

Test Plan

Currently, we can't test this linter with out existing infrastructure. Specifically, jscs will only lint *.js files. I have done a fair bit of manual testing though.

Diff Detail

Repository
rARC Arcanist
Branch
jscs
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1145
Build 1145: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22926.Jun 15 2014, 11:43 PM
joshuaspence retitled this revision from to Add an `ArcanistJscsLinter`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 15 2014, 11:43 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1132: Diff 22926.Jun 15 2014, 11:44 PM
joshuaspence updated this revision to Diff 22946.Jun 16 2014, 6:06 PM
joshuaspence edited edge metadata.

Update issue number because issue 346 is closed but did not fix the issue.

Harbormaster completed remote builds in B1145: Diff 22946.Jun 16 2014, 6:07 PM
epriestley accepted this revision.Jun 16 2014, 6:37 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2014, 6:37 PM
joshuaspence closed this revision.Jun 16 2014, 8:40 PM
joshuaspence updated this revision to Diff 22961.

Closed by commit rARCb1ddd0f03b2a (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
4 lines
lint/
linter/
154 lines
__tests__/
17 lines
jscs/
12 lines

Diff 22946

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/ArcanistJscsLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistJscsLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/jscs/curly-brace.lint-test

Loading...
Phabricator · Built by Phacility