Page MenuHomePhabricator
Differential D9546

Fix phutil_utf8_console_strlen() for combining characters
ClosedPublic
Actions

Authored by epriestley on Jun 15 2014, 1:08 PM.
Tags
None
Referenced Files
F13987835: D9546.diff
Mon, Oct 21, 11:36 AM
F13984467: D9546.id.diff
Sun, Oct 20, 1:36 PM
F13956342: D9546.id22879.diff
Mon, Oct 14, 5:14 AM
Unknown Object (File)
Fri, Oct 11, 1:43 AM
Unknown Object (File)
Sep 15 2024, 7:25 AM
Unknown Object (File)
Aug 29 2024, 7:50 PM
Unknown Object (File)
Aug 27 2024, 10:55 PM
Unknown Object (File)
Aug 19 2024, 3:00 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
Commits
rPHUfe71010796fb: Fix phutil_utf8_console_strlen() for combining characters
Summary

See D9533. We currently count the length of combining characters incorrectly.

Instead, break the string into glyphs first, then only count the length of the base character in each glyph, ignoring combining characters.

Test Plan

Added some unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
consolelen
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1108
Build 1108: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22879.Jun 15 2014, 1:08 PM
epriestley retitled this revision from to Fix phutil_utf8_console_strlen() for combining characters.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 15 2014, 1:08 PM
Harbormaster completed remote builds in B1108: Diff 22879.Jun 15 2014, 1:10 PM
joshuaspence accepted this revision.Jun 15 2014, 5:42 PM
joshuaspence edited edge metadata.

This fixes my issue.

This revision is now accepted and ready to land.Jun 15 2014, 5:42 PM
epriestley closed this revision.Jun 15 2014, 5:51 PM
epriestley updated this revision to Diff 22891.

Closed by commit rPHUfe71010796fb (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
utils/
__tests__/
6 lines
55 lines

Diff 22879

View Options

src/utils/__tests__/PhutilUTF8TestCase.php

Loading...
View Options

src/utils/utf8.php

Loading...
Phabricator · Built by Phacility