Page MenuHomePhabricator

Fix a problem with recording image replacement, every other mock update
ClosedPublic

Authored by epriestley on Jun 15 2014, 3:08 AM.
Tags
None
Referenced Files
F13325459: D9541.id.diff
Sat, Jun 15, 1:52 AM
F13325458: D9541.id22872.diff
Sat, Jun 15, 1:52 AM
F13325456: D9541.id22867.diff
Sat, Jun 15, 1:52 AM
F13325204: D9541.diff
Sat, Jun 15, 1:31 AM
F13319848: D9541.diff
Thu, Jun 13, 3:31 PM
F13251893: D9541.diff
Sat, May 25, 12:51 AM
F13246911: D9541.id22872.diff
Thu, May 23, 2:22 PM
F13181638: D9541.id22867.diff
May 9 2024, 2:02 PM
Subscribers

Details

Summary

This fixes a weird issue which currently doesn't have much impact on things, but starts to matter if we do the grid.

We're incorrectly initializing the form with replacesPHID as the previously replaced Image PHID. It is supposed to be the current File PHID.

Every other time, this is null and things work properly. On even updates (2, 4, 6, etc.), it's wrong and we don't record the replacement completely correctly.

Test Plan

Replaced images twice, saw three rows of thumb grid.

Diff Detail

Repository
rP Phabricator
Branch
phyx1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1100
Build 1100: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix a problem with recording image replacement, every other mock update.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2014, 3:10 AM
epriestley updated this revision to Diff 22872.

Closed by commit rP3a36f1e31c54 (authored by @epriestley).