Fix a problem with recording image replacement, every other mock update
ClosedPublic
Actions

Authored by epriestley on Jun 15 2014, 3:08 AM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP3a36f1e31c54: Fix a problem with recording image replacement, every other mock update

Summary

This fixes a weird issue which currently doesn't have much impact on things, but starts to matter if we do the grid.

We're incorrectly initializing the form with replacesPHID as the previously replaced Image PHID. It is supposed to be the current File PHID.

Every other time, this is null and things work properly. On even updates (2, 4, 6, etc.), it's wrong and we don't record the replacement completely correctly.

Test Plan

Replaced images twice, saw three rows of thumb grid.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22867.Jun 15 2014, 3:08 AM

epriestley retitled this revision from to Fix a problem with recording image replacement, every other mock update.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 15 2014, 3:08 AM

Harbormaster completed remote builds in B1100: Diff 22867.Jun 15 2014, 3:09 AM

chad accepted this revision.Jun 15 2014, 3:10 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2014, 3:10 AM

Closed by commit rP3a36f1e31c54 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

controller/

PholioMockEditController.php

12 lines

Diff 22872

View Options

src/applications/pholio/controller/PholioMockEditController.php

Fix a problem with recording image replacement, every other mock updateClosedPublicActions