Page MenuHomePhabricator
Differential D9500

Allow users to select QueryPanel search engines from a list
ClosedPublic
Actions

Authored by epriestley on Jun 12 2014, 11:00 AM.
Tags
None
Referenced Files
F18772852: D9500.id22769.diff
Thu, Oct 9, 5:17 AM
F18765512: D9500.id.diff
Tue, Oct 7, 11:38 AM
F18759522: D9500.diff
Mon, Oct 6, 4:22 AM
F18753550: D9500.diff
Sat, Oct 4, 7:25 PM
F18650575: D9500.diff
Sun, Sep 21, 1:06 AM
F18617258: D9500.diff
Sep 14 2025, 8:43 PM
F18615901: D9500.id22757.diff
Sep 14 2025, 3:21 PM
F18613921: D9500.id22769.diff
Sep 14 2025, 11:39 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T4986: Implement new Dashboard panel types
Commits
Restricted Diffusion Commit
rPb8bc0aa2b058: Allow users to select QueryPanel search engines from a list
Summary

Ref T4986. Instead of requiring users to know the name of an application search engine class, let them select from a list.

Test Plan

Created a new panel.

Screen_Shot_2014-06-12_at_3.59.12_AM.png (1×621 px, 104 KB)

Diff Detail

Repository
rP Phabricator
Branch
dash2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1030
Build 1030: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22757.Jun 12 2014, 11:00 AM
epriestley retitled this revision from to Allow users to select QueryPanel search engines from a list.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4986: Implement new Dashboard panel types.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 12 2014, 11:00 AM
Harbormaster completed remote builds in B1030: Diff 22757.Jun 12 2014, 11:01 AM
chad accepted this revision.Jun 12 2014, 2:15 PM
chad edited edge metadata.

I see a lot of testing in my future.

This revision is now accepted and ready to land.Jun 12 2014, 2:15 PM
chad added a comment.Jun 12 2014, 3:06 PM

Wondering if these should be a typeahead - but very happy for them either way.

epriestley closed this revision.Jun 12 2014, 8:22 PM
epriestley updated this revision to Diff 22769.

Closed by commit rPb8bc0aa2b058 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
audit/
query/
4 lines
calendar/
query/
4 lines
conduit/
query/
4 lines
countdown/
query/
4 lines
dashboard/
customfield/
40 lines
paneltype/
6 lines
query/
4 lines
4 lines
differential/
query/
4 lines
diviner/
query/
4 lines
drydock/
query/
4 lines
4 lines
4 lines
4 lines
feed/
query/
4 lines
files/
query/
4 lines
flag/
query/
4 lines
harbormaster/
query/
4 lines
4 lines
herald/
query/
4 lines
4 lines
legalpad/
query/
4 lines
macro/
query/
4 lines
mailinglists/
query/
4 lines
maniphest/
query/
4 lines
meta/
query/
4 lines
oauthserver/
query/
4 lines
passphrase/
query/
4 lines
paste/
query/
4 lines
people/
query/
4 lines
4 lines
pholio/
query/
4 lines
phrequent/
query/
4 lines
phriction/
query/
4 lines
ponder/
query/
4 lines
project/
query/
4 lines
releeph/
query/
4 lines
4 lines
4 lines
repository/
query/
4 lines
4 lines
search/
engine/
12 lines
query/
4 lines
slowvote/
query/
4 lines

Diff 22757

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitSearchEngine.php

Loading...
View Options

src/applications/countdown/query/PhabricatorCountdownSearchEngine.php

Loading...
View Options

src/applications/dashboard/customfield/PhabricatorDashboardPanelSearchApplicationCustomField.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeQuery.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/diviner/query/DivinerAtomSearchEngine.php

Loading...
View Options

src/applications/drydock/query/DrydockBlueprintSearchEngine.php

Loading...
View Options

src/applications/drydock/query/DrydockLeaseSearchEngine.php

Loading...
View Options

src/applications/drydock/query/DrydockLogSearchEngine.php

Loading...
View Options

src/applications/drydock/query/DrydockResourceSearchEngine.php

Loading...
View Options

src/applications/feed/query/PhabricatorFeedSearchEngine.php

Loading...
View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...
View Options

src/applications/flag/query/PhabricatorFlagSearchEngine.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...
View Options

src/applications/herald/query/HeraldRuleSearchEngine.php

Loading...
View Options

src/applications/herald/query/HeraldTranscriptSearchEngine.php

Loading...
View Options

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...
View Options

src/applications/mailinglists/query/PhabricatorMailingListSearchEngine.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
View Options

src/applications/meta/query/PhabricatorAppSearchEngine.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php

Loading...
View Options

src/applications/passphrase/query/PassphraseCredentialSearchEngine.php

Loading...
View Options

src/applications/paste/query/PhabricatorPasteSearchEngine.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleLogSearchEngine.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleSearchEngine.php

Loading...
View Options

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...
View Options

src/applications/phrequent/query/PhrequentSearchEngine.php

Loading...
View Options

src/applications/phriction/query/PhrictionSearchEngine.php

Loading...
View Options

src/applications/ponder/query/PonderQuestionSearchEngine.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephBranchSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephProductSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephRequestSearchEngine.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
Phabricator · Built by Phacility