Page MenuHomePhabricator
Differential D9489

Tweak error and status messages for commit ranges
ClosedPublic
Actions

Authored by epriestley on Jun 11 2014, 10:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 6:23 AM
Unknown Object (File)
Mon, Dec 16, 6:39 PM
Unknown Object (File)
Sun, Dec 15, 5:14 AM
Unknown Object (File)
Thu, Dec 12, 4:39 AM
Unknown Object (File)
Sat, Dec 7, 12:44 PM
Unknown Object (File)
Fri, Dec 6, 8:16 PM
Unknown Object (File)
Tue, Dec 3, 6:40 PM
Unknown Object (File)
Tue, Dec 3, 6:40 PM
View All Files
Subscribers
epriestley

Details

Reviewers
talshiri
Commits
rARC9492b4ecba12: Tweak error and status messages for commit ranges
Summary

Improve/clarify some error messages a bit, hopefully.

Test Plan

Ran arc which, arc diff, etc., with various explicit, implicit, and --head flags. Read error messages, didn't catch anything too awkward.

Diff Detail

Repository
rARC Arcanist
Branch
messages
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1019
Build 1019: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22723.Jun 11 2014, 10:30 PM
epriestley retitled this revision from to Tweak error and status messages for commit ranges.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: talshiri.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 11 2014, 10:30 PM
Harbormaster completed remote builds in B1018: Diff 22723.Jun 11 2014, 10:31 PM
epriestley updated this revision to Diff 22725.Jun 11 2014, 10:32 PM
  • Use %R ("Readable Argument") in the Mercurial construction.
Harbormaster completed remote builds in B1019: Diff 22725.Jun 11 2014, 10:33 PM
talshiri added inline comments.Jun 11 2014, 10:52 PM
src/repository/api/ArcanistGitAPI.php
132

getBaseCommit() returns a SHA?

149–153

This is exactly infinite time better than my phrasing

epriestley added inline comments.Jun 11 2014, 10:56 PM
src/repository/api/ArcanistGitAPI.php
132

It may or may not return a SHA. If invoked as arc diff X, it will return a SHA, but if a --base rule is used to figure it out it may not.

talshiri accepted this revision.Jun 11 2014, 10:58 PM
talshiri edited edge metadata.
talshiri added inline comments.
src/repository/api/ArcanistGitAPI.php
132

oic

This revision is now accepted and ready to land.Jun 11 2014, 10:58 PM
epriestley closed this revision.Jun 11 2014, 11:35 PM
epriestley updated this revision to Diff 22746.

Closed by commit rARC9492b4ecba12 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
repository/
api/
76 lines
workflow/
21 lines
47 lines

Diff 22725

View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
View Options

src/workflow/ArcanistWhichWorkflow.php

Loading...
Phabricator · Built by Phacility