Page MenuHomePhabricator
Differential D9487

Move subscription updates to the `register` function.
ClosedPublic
Actions

Authored by joshuaspence on Jun 11 2014, 8:51 PM.
Tags
None
Referenced Files
F14059584: D9487.diff
Sun, Nov 17, 8:35 PM
F14048821: D9487.diff
Thu, Nov 14, 9:50 AM
F14037306: D9487.diff
Sun, Nov 10, 3:03 PM
F14033505: D9487.diff
Sat, Nov 9, 5:50 PM
F14019813: D9487.diff
Tue, Nov 5, 11:40 PM
F14011089: D9487.id22712.diff
Thu, Oct 31, 5:20 PM
F14011047: D9487.diff
Thu, Oct 31, 4:01 PM
F13987860: D9487.id.diff
Mon, Oct 21, 11:51 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5284: Allow users to receive Aphlict notifications for an object they are viewing
Commits
Restricted Diffusion Commit
rPaa534c69f042: Move subscription updates to the `register` function.
Summary

Currently, the AphlictClient will only send its subscriptions to the AphlictMaster once. If the original AphlictMaster is closed and a new master is created, then client subscriptions will be lost.

Test Plan

Opened two separate tabs. Closed the "master" tab and noticed that the subscriptions were re-sent to the server.

Diff Detail

Repository
rP Phabricator
Branch
aphlict-client
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1013
Build 1013: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22709.Jun 11 2014, 8:51 PM
joshuaspence retitled this revision from to Move subscription notifications to the `register` function..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 11 2014, 8:51 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
joshuaspence planned changes to this revision.Jun 11 2014, 8:52 PM

Hold up on this.

Harbormaster completed remote builds in B1013: Diff 22709.Jun 11 2014, 8:53 PM
joshuaspence requested a review of this revision.Jun 11 2014, 9:01 PM

OK yeah this seems to work for me.

joshuaspence retitled this revision from Move subscription notifications to the `register` function. to Move subscription updates to the `register` function..Jun 11 2014, 9:03 PM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
epriestley accepted this revision.Jun 11 2014, 9:08 PM
epriestley edited edge metadata.

Nice, this feels cleaner even ignoring the bit where it fixes an issue.

This revision is now accepted and ready to land.Jun 11 2014, 9:08 PM
epriestley closed this revision.Jun 11 2014, 9:09 PM
epriestley updated this revision to Diff 22712.

Closed by commit rPaa534c69f042 (authored by @joshuaspence, committed by @epriestley).

joshuaspence added a task: T5284: Allow users to receive Aphlict notifications for an object they are viewing.Jun 11 2014, 9:27 PM

Revision Contents
Changeset List

PathSize
support/
aphlict/
client/
src/
27 lines
webroot/
rsrc/
swf/

Diff 22709

View Options

support/aphlict/client/src/AphlictClient.as

Loading...
View Options

webroot/rsrc/swf/aphlict.swf

Loading...
Phabricator · Built by Phacility