Move subscription updates to the `register` function.
ClosedPublic
Actions

Authored by joshuaspence on Jun 11 2014, 8:51 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5284: Allow users to receive Aphlict notifications for an object they are viewing

Commits

Restricted Diffusion Commit
rPaa534c69f042: Move subscription updates to the `register` function.

Summary

Currently, the AphlictClient will only send its subscriptions to the AphlictMaster once. If the original AphlictMaster is closed and a new master is created, then client subscriptions will be lost.

Test Plan

Opened two separate tabs. Closed the "master" tab and noticed that the subscriptions were re-sent to the server.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22709.Jun 11 2014, 8:51 PM

joshuaspence retitled this revision from to Move subscription notifications to the `register` function..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 11 2014, 8:51 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Hold up on this.

Harbormaster completed remote builds in B1013: Diff 22709.Jun 11 2014, 8:53 PM

OK yeah this seems to work for me.

joshuaspence retitled this revision from Move subscription notifications to the `register` function. to Move subscription updates to the `register` function..Jun 11 2014, 9:03 PM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence edited edge metadata.