Page MenuHomePhabricator

Use JS to manage dashboard tab panels
ClosedPublic

Authored by epriestley on Jun 11 2014, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 4:53 AM
Unknown Object (File)
Sun, Jan 5, 7:21 AM
Unknown Object (File)
Dec 30 2024, 10:18 AM
Unknown Object (File)
Dec 30 2024, 10:14 AM
Unknown Object (File)
Dec 20 2024, 6:37 PM
Unknown Object (File)
Dec 13 2024, 12:23 PM
Unknown Object (File)
Dec 4 2024, 10:44 AM
Unknown Object (File)
Nov 26 2024, 11:01 PM
Subscribers

Details

Summary

Fixes T5271. This is mostly similar to normal tab panel JS, but I think we'll eventually do async rendering and/or saved tabs so it's reasonable to split it out.

Test Plan

Toggled tabs on a tab panel, saw tab selected state change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use JS to manage dashboard tab panels.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 11 2014, 4:34 PM
epriestley updated this revision to Diff 22674.

Closed by commit rPce887d55c2e5 (authored by @epriestley).