Differential D9472
Fall back to slow UTF8 algorithms that don't crash Authored by epriestley on Jun 11 2014, 2:02 PM. Tags None Referenced Files
Subscribers
Details Fixes T5316. PCRE can blow stacks on (x|y)+ regexps, and a user is hitting a consistent fatal in PCRE. Rewrite the fallback for phutil_is_utf8() to be iterative. This is somewhat slower, but not normally too horrible, and we have a variety of ways to mitigate that if it arises as a real issue (encourage installation of mb extension, ship a fast C extension, etc). We already have most of this code anyway. We have fairly good test coverage here already, I mostly just realigned the existing test coverage to explicitly call the new code.
Diff Detail
Event TimelineComment Actions Tested and works for me on the changeset that was displaying this issue. It did prompt to mark 2 of the files in the diff as binary, but allowed the revision to be posted. |