Page MenuHomePhabricator
Create Task
Maniphest T5316

`arc` segfaulting inside PCRE during utf8 operations (particularly on Windows)
Closed, ResolvedPublic
Actions

Description

See some context in IRC.

Here's a trace:

https://gist.github.com/webframp/5036fc92c7ba1f575a4e

...after which everything apparently dies with no meaningful error output.

Revisions and Commits

rPHU libphutil
D9472rPHUf1e0aedec85b Fall back to slow UTF8 algorithms that don't crash

Event Timeline

epriestley created this task.Jun 11 2014, 1:30 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Arcanist.
epriestley added subscribers: epriestley, webframp.

No-opping phutil_is_utf8() fixed the crash, so this is almost certainly an issue with PCRE choking on large UTF8 input.

epriestley edited this Maniphest Task.Jun 11 2014, 2:02 PM
epriestley renamed this task from `arc` completely crashing for some Windows users to `arc` segfaulting inside PCRE during utf8 operations (particularly on Windows).Jun 11 2014, 2:12 PM
yevhenii.dumskyi edited this Maniphest Task.Jun 13 2014, 8:59 AM
yevhenii.dumskyi edited this Maniphest Task.
epriestley edited this Maniphest Task.Jun 20 2014, 6:48 PM
epriestley closed this task as Resolved.Jun 20 2014, 6:48 PM

Closed by commit rPHUf1e0aedec85b.

Phabricator · Built by Phacility